feat build: prefere static libs when possible #821
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
apolukhin
reviewed
Jan 6, 2025
| @@ -1,12 +0,0 @@ | |||
| _userver_module_begin( | |||
| NAME SSL | |||
| COMMON_NAME OpenSSL | |||
There was a problem hiding this comment.
OpenSSL был последним cmake файлом использующим COMMON_NAME для _userver_module_begin. Можно будет ощутимо упростить userver_module* функции
There was a problem hiding this comment.
понял, попробую изничтожить тогда
FindOpenSSL вроде бы с симейка 3.4 доступен, поэтому эти модули не нужны (да и они кажется не использовались вообще)
fdr400
commented
Jan 6, 2025
CMakeLists.txt
Outdated
| @@ -143,6 +143,11 @@ option(USERVER_FEATURE_OTLP "Provide asynchronous OTLP exporters" "${USERVER_LIB | |||
|
|
|||
| set(CMAKE_DEBUG_POSTFIX d) | |||
|
|
|||
| set(OPENSSL_USE_STATIC_LIBS ON) | |||
There was a problem hiding this comment.
Это стоит в опцию какой-нибудь обернуть, потому что у нас явно не везде всё для статических либ готово
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Note: by creating a PR or an issue you automatically agree to the CLA. See CONTRIBUTING.md. Feel free to remove this note, the agreement holds.