Skip to content

Commit 0e2edf3

Browse files
authored
Merge pull request #45 from kpavlov00/grpc-server-usability
feat grpc: switch to simplified service handlers interface
2 parents 00da460 + 9de6ac9 commit 0e2edf3

File tree

2 files changed

+5
-5
lines changed

2 files changed

+5
-5
lines changed

src/hello.cpp

+3-3
Original file line numberDiff line numberDiff line change
@@ -8,8 +8,8 @@
88

99
namespace pg_grpc_service_template {
1010

11-
void Hello::SayHello(handlers::api::HelloServiceBase::SayHelloCall& call,
12-
handlers::api::HelloRequest&& request) {
11+
Hello::SayHelloResult Hello::SayHello(CallContext& /*context*/,
12+
handlers::api::HelloRequest&& request) {
1313
auto name = request.name();
1414

1515
auto user_type = UserType::kFirstTime;
@@ -31,7 +31,7 @@ void Hello::SayHello(handlers::api::HelloServiceBase::SayHelloCall& call,
3131
}
3232
handlers::api::HelloResponse response;
3333
response.set_text(pg_grpc_service_template::SayHelloTo(name, user_type));
34-
call.Finish(response);
34+
return response;
3535
}
3636

3737
std::string SayHelloTo(std::string_view name, UserType type) {

src/hello.hpp

+2-2
Original file line numberDiff line numberDiff line change
@@ -27,8 +27,8 @@ class Hello final : public handlers::api::HelloServiceBase::Component {
2727
.GetCluster()),
2828
client_(component_context.FindComponent<HelloClient>()) {}
2929

30-
void SayHello(handlers::api::HelloServiceBase::SayHelloCall& call,
31-
handlers::api::HelloRequest&& request);
30+
SayHelloResult SayHello(CallContext& context,
31+
handlers::api::HelloRequest&& request);
3232

3333
private:
3434
userver::storages::postgres::ClusterPtr pg_cluster_;

0 commit comments

Comments
 (0)