feat: move requests between collections #5410

jayakrishnancn · 2025-08-23T14:45:08Z

Description

Move requests between collections.
Move requests/folders between collections using drag and drop. Currently it is only possible to move requests/folders within a collection.
while moving, if the target collection or folder has the same request/folder, then rename the new dropped folder/request and move it to the new target

resolves #3320

Screen.Recording.2025-08-23.at.8.12.26.PM.mov

Contribution Checklist:

The pull request only addresses one issue or adds one feature.
The pull request does not introduce any breaking changes
I have added screenshots or gifs to help explain the change if applicable.
I have read the contribution guidelines.
Create an issue and link to the pull request.

Note: Keeping the PR small and focused helps make it easier to review and merge. If you have multiple changes you want to make, please consider submitting them as separate pull requests.

Publishing to New Package Managers

Please see here for more information.

…another

helloanoop · 2025-09-01T10:35:54Z

Thank you, @jayakrishnancn!
We’ve scheduled this for review in the first half of September.

sanish-bruno · 2025-09-04T07:26:38Z

Hi @jayakrishnancn, Thanks a lot for working on this. It works well when it comes to moving requests/folders across the collections. I was testing the PR on my local and found a major issue within the PR, , for some reason none of the grpc requests are not copied over. I have added sample grpc collection export json, screen recording for your reference.

On top of this - I guess we will have to expand the playwright test-cases to accomodate this scenario
Also i think it will better to have a drop indication border for collection too, similar to folder, currently only a line appear, give us an impression that it being dropped in between the collection

I guess we can add similar
Grpcbin-sample.json

Screen.Recording.2025-09-04.at.12.51.52.PM.mov

jayakrishnancn · 2025-09-04T08:33:11Z

Hi @sanish-bruno,
great catch!
This bug wasn't introduced in this PR; it's an existing issue.
https://github.com/usebruno/bruno/blob/e0b3b1a/packages/bruno-electron/src/ipc/collection.js#L702

However, I've included a fix for it in my latest commit. I'm reusing the "clone-folder," where the 'grpc-request' option was missing. Ideally, all requests should be cloned, in my opinion, and shouldn't be limited to just a few types. Since I'm not sure about the impact of removing the .includes condition, I won't remove it. I'll just add the grpc option to it.

If you suggest removing it, I can do that through another bugfix PR.

Before my change (existing main branch code):

Cloning a gRPC request within a collection wasn't functioning properly in main branch code:

before.mov

after the chagnes:
Both cloning folders within a collection and moving folders across collections using gRPC requests are functioning as expected after my changes.

Screen.Recording.2025-09-04.at.1.48.11.PM.mov

jayakrishnancn · 2025-09-04T08:36:04Z

On top of this - I guess we will have to expand the playwright test-cases to accomodate this scenario

can you clarify on this? I have already added few cases in the test files
this covers drag and drop of both requests and folders.

e2e-tests/003-collection-management-tests/001-cross-collection-drag-drop-request.spec.ts
e2e-tests/003-collection-management-tests/001-cross-collection-drag-drop-request.spec.ts

sanishchirayath1 · 2025-09-04T08:44:52Z

On top of this - I guess we will have to expand the playwright test-cases to accomodate this scenario

can you clarify on this? I have already added few cases in the test files
this covers drag and drop of both requests and folders.

e2e-tests/003-collection-management-tests/001-cross-collection-drag-drop-request.spec.ts

e2e-tests/003-collection-management-tests/001-cross-collection-drag-drop-request.spec.ts

Scenarios where we have grpc, http, graphql requests within a folder and all of them are moved successfully

sanish-bruno · 2025-09-04T09:09:58Z

packages/bruno-app/src/components/Sidebar/Collections/Collection/CollectionItem/index.js


-      await dispatch(handleCollectionItemDrop({ targetItem: item, draggedItem, dropType, collectionUid }))
+      // Handle cross-collection drops differently
+      if (sourceCollectionUid !== collectionUid) {


@jayakrishnancn do we need the check here? we can just pass the 'sourceCollectoionUid' and handle it from handleCollectionItemDrop function?

Makes sense. Removed the guard 'if' condition.

sanish-bruno · 2025-09-04T09:10:52Z

packages/bruno-app/src/components/Sidebar/Collections/Collection/index.js

      if (isCollectionItem(itemType)) {
-        dispatch(handleCollectionItemDrop({ targetItem: collection, draggedItem, dropType: 'inside', collectionUid: collection.uid }))
+        // Handle cross-collection drops
+        if (draggedItem.sourceCollectionUid && draggedItem.sourceCollectionUid !== collection.uid) {


do we need the check here? we can just pass the 'sourceCollectoionUid' and handle it from handleCollectionItemDrop function if it is undefined, same as above?

Made adjustments.

sanish-bruno · 2025-09-04T09:22:55Z

packages/bruno-app/src/components/Sidebar/Collections/Collection/CollectionItem/index.js

    if (draggedItemUid === targetItemUid) return false;

+    // For cross-collection moves, we allow the drop
+    if (sourceCollectionUid !== collectionUid) {


@jayakrishnancn I guess we can add this logic inside calculateDraggedItemNewPathname function, were we will return a newPathname according to the collection pathname.

Don't have the clarity one when it will happen but what if sourceCollectionId is undefined, the function will return true leading into some error/failure along the line.

What are your thought on this?

As far as I know, every item being dragged should have a unique ID. While being undefined is valid in isolation, sourceCollectionUid is set during drag initialization. The drag system ensures this property when dragging begins.

I guess we can add this logic inside calculateDraggedItemNewPathname function, were we will return a newPathname according to the collection pathname.

Personally, I’m not in favor of moving this logic to the calculateDraggedItemNewPathname method, as its purpose is to return the pathname, not to determine if it’s a cross-collection.
Additionally, calculateDraggedItemNewPathname is also utilized in handleReorderInSameLocation. I'm unsure about the impact of modifying it.

if you still believe moving it makes sense, we can make the changes

sanish-bruno · 2025-09-04T09:37:42Z

packages/bruno-app/src/providers/ReduxStore/slices/collections/actions.js

+
+    // Handle cross-collection moves
+    if (sourceCollectionUid && sourceCollectionUid !== collectionUid) {
+      return dispatch(handleCrossCollectionItemMove({ 


@jayakrishnancn Just out of curiosity, do we need a extra handleCrossCollectionItemMove function? is it possible to make little modifications to the existing logic to handle this?
For example:
we can generate targetItemDirectory (L 735) , draggedItemDirectory (L 737) from collectionUid , sourceCollectionUid respectively.

Have you tried that approach before?
I was thinking of hassle of maintaining two different functions that almost handle similar functionality. Let me know if you think it is better to keep them seperate.

At first, I thought of adding features like renaming through generateUniqueFilename() when duplicate request names exist in a collection/folders, since I usually work with collectionswhere this happens. However, I didn’t want to modify the current code.

After thinking it through, you’re right—reusing the method without renaming is better. In the case of duplicates, we can show an error toast. Later, if needed, we can introduce the renaming feature in a different PR if required

sanish-bruno · 2025-09-04T09:39:18Z

Hi @sanish-bruno, great catch! This bug wasn't introduced in this PR; it's an existing issue. https://github.com/usebruno/bruno/blob/e0b3b1a/packages/bruno-electron/src/ipc/collection.js#L702

However, I've included a fix for it in my latest commit. I'm reusing the "clone-folder," where the 'grpc-request' option was missing. Ideally, all requests should be cloned, in my opinion, and shouldn't be limited to just a few types. Since I'm not sure about the impact of removing the .includes condition, I won't remove it. I'll just add the grpc option to it.

If you suggest removing it, I can do that through another bugfix PR.

Before my change (existing main branch code):

Cloning a gRPC request within a collection wasn't functioning properly in main branch code:

before.mov
after the chagnes: Both cloning folders within a collection and moving folders across collections using gRPC requests are functioning as expected after my changes.

Screen.Recording.2025-09-04.at.1.48.11.PM.mov

Yup make sense, thanks for fixing it! we will be keeping the .includes for now. But yes removing the check is something we can think of. not right now.

jayakrishnancn · 2025-09-06T07:14:32Z

Hi @sanish-bruno,
Please re-review the PR.

I have updated the UX as well. While dropping, instead of showing a line, it now displays a complete border, similar to a folder drop. Additionally, in case of a duplicate request during dropping, it will now show the default error message.

Screen.Recording.2025-09-06.at.11.59.47.AM.mov

jayakrishnancn · 2025-09-06T07:16:40Z

Scenarios where we have grpc, http, graphql requests within a folder and all of them are moved successfully

For some reason, I couldn't find the gRPC option under "new request," so I skipped writing the scenario where the folder includes a gRPC request..

sanish-bruno · 2025-09-06T08:13:18Z

@jayakrishnancn currently gRPC is in beta, you can enable it from preferences -> beta -> enable grpc, we just hidden the entry points until it is out of beta https://docs.usebruno.com/send-requests/grpc/overview, but you can ignore the grpc-requests for now! we can write a playwright test case once it is out of beta

sanish-bruno · 2025-09-08T11:11:15Z

@jayakrishnancn i rebased, squashed commits moved the test files to a new folder as per the main branch and raised a new PR #5525 Thanks for working on this! We will try to get it merged for upcoming release that will ideally happen in 2 weeks time.

helloanoop · 2025-09-08T14:36:14Z

@jayakrishnancn We made some changes on top of your PR and have merged it.

Thank you!

jayakrishnancn added 7 commits August 23, 2025 16:57

feat: Move requests between collections usebruno#3320

33ed377

test: update e2e test case for moving request from one collection to …

88d2789

…another

test: updated the tests

000f8bc

test: added more test cases

72f0d27

test: e2e test updated

7d48eed

test: fixed test case

a5c3a67

test: fixed test cause for folder

724659f

jayakrishnancn requested review from bijin-bruno, helloanoop, lohit-bruno, maintainer-bruno and naman-bruno as code owners August 23, 2025 14:45

pull-request-size bot added the size/XL label Aug 23, 2025

This was referenced Aug 23, 2025

Move requests between collections #3320

Closed

Feature Request: allow us to clone an API request between collections #860

Open

jayakrishnancn changed the title ~~Move requests between collections~~ feat: Move requests between collections Aug 25, 2025

jayakrishnancn changed the title ~~feat: Move requests between collections~~ feat: move requests between collections Aug 25, 2025

fix: add grpc-request to clone-folder

f046971

sanish-bruno suggested changes Sep 4, 2025

View reviewed changes

jayakrishnancn added 2 commits September 5, 2025 13:28

fix: removed handleCrossCollectionItemMove method

1cab8cb

test: updated e2e test cases

6a9e3f8

pull-request-size bot added size/L and removed size/XL labels Sep 5, 2025

fix: removed cross-collection gurard statement

1a84a72

jayakrishnancn force-pushed the feature/move-requests-between-collections branch from 2d01d3e to 1a84a72 Compare September 5, 2025 10:25

jayakrishnancn added 2 commits September 5, 2025 16:03

format: revert format

b3a2937

fix: UX changes for collection drag and drop

f456a6c

sanish-bruno approved these changes Sep 8, 2025

View reviewed changes

sanish-bruno mentioned this pull request Sep 8, 2025

Feature: moving requests cross collection #5525

Merged

5 tasks

helloanoop closed this Sep 8, 2025

feat: move requests between collections #5410

feat: move requests between collections #5410

Uh oh!

Conversation

jayakrishnancn commented Aug 23, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Description

Contribution Checklist:

Publishing to New Package Managers

Uh oh!

helloanoop commented Sep 1, 2025

Uh oh!

sanish-bruno commented Sep 4, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

jayakrishnancn commented Sep 4, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

jayakrishnancn commented Sep 4, 2025

Uh oh!

sanishchirayath1 commented Sep 4, 2025

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

sanish-bruno commented Sep 4, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

jayakrishnancn commented Sep 6, 2025

Uh oh!

jayakrishnancn commented Sep 6, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

sanish-bruno commented Sep 6, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

sanish-bruno commented Sep 8, 2025

Uh oh!

helloanoop commented Sep 8, 2025

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

jayakrishnancn commented Aug 23, 2025 •

edited

Loading

sanish-bruno commented Sep 4, 2025 •

edited

Loading

jayakrishnancn commented Sep 4, 2025 •

edited

Loading

sanish-bruno commented Sep 4, 2025 •

edited

Loading

jayakrishnancn commented Sep 6, 2025 •

edited

Loading

sanish-bruno commented Sep 6, 2025 •

edited

Loading