Skip to content

Missing key autoquoting required when special characters in input field #5462

@pietrygamat

Description

@pietrygamat

After merging #3178, and updating the Ohm grammar for bru-lang, the type dictionary now supports optionally quoted keys. There are several places in the app, where such dictionary may have keys containing : as a valid character, but not autoquoted when saving:

  • ❌ Collection level headers - not autoquoted if conain (:)
  • ✔️ Collection level vars - input validated, : not allowed
  • ❌ Collection level auth:oauth2:additional_params - not autoquoted if contain (:)
  • ✔️ Request level query params - correctly autoquoted on save
  • ⚠️ Request level path params - confusing reformat on save - see below - but colons in path param names make little sense, so this may be ignored
  • ✔️Request body - multipart/url-encoded - correctly autoquoted on save
  • ✔️Request level headers - fixed in linked PR
  • ❌ Request level auth:oauth2:additional_params - not autoquoted if contain (:)
  • ✔️ Request level vars - input validated, : not allowed
  • ❌ Request level asserts - Expr may take :, but it gets moved to value on save. No either of autoquoting or input validation as in vars tab.
  • ✔️ Request level tags - input validated and limited.

*) Request query params while typing multiple : into address field pre and post save:
Image Image

Metadata

Metadata

Assignees

Labels

No labels
No labels

Type

No type

Projects

No projects

Milestone

No milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions