Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Introduce ContextVars #24

Open
ubmarco opened this issue Dec 5, 2022 · 0 comments
Open

Introduce ContextVars #24

ubmarco opened this issue Dec 5, 2022 · 0 comments
Assignees
@ubmarco
Labels
enhancement New feature or request

Comments

@ubmarco
Copy link
Member

ubmarco commented Dec 5, 2022 •
edited
Loading

Injecting context information to user models shall be migrated to ContextVars according to this solution.

This has 2 advantages:

  • the custom base class can be removed
  • it looks like pydantic v2 also goes this direction

Need to check whether they can be shared across multiple modules as sphinx-modeling creates them and the user models consume them.
@ubmarco ubmarco added the enhancement New feature or request label Dec 5, 2022
@ubmarco ubmarco self-assigned this Dec 5, 2022
@ubmarco ubmarco modified the milestone: 0.2.0 Dec 5, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@ubmarco ubmarco

Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@ubmarco