Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update hash as you scroll #239

Open
bertday opened this issue Feb 19, 2021 · 0 comments
Open

Update hash as you scroll #239

bertday opened this issue Feb 19, 2021 · 0 comments

Comments

@bertday
Copy link

bertday commented Feb 19, 2021

This is a fantastic guide for better public-interest technology—a big thank you to USDS for the work and vision that went into this!

I had one small suggestion, which was that the hash (e.g. #play-7) could update each time you scroll to a new play. The user story I had in mind was:

  • You're scrolling and land on a play you think is interesting and want to share
  • You share the URL with someone, or post to social media
  • The person/audience you share it with clicks and lands directly on that play

It looks like there's already a listener on scrolling that highlights the current play in the top-level nav, so maybe the hash update could happen in that hook? I'd be happy to try a PR for this if it seems helpful!

Robert

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant