Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Issue]: Edit Note - add Edit/Delete dropdown #3591

Open
ClaireValdivia opened this issue Oct 7, 2024 · 1 comment
Open

[Issue]: Edit Note - add Edit/Delete dropdown #3591

ClaireValdivia opened this issue Oct 7, 2024 · 1 comment
Assignees
Labels
Grant Finder Issues related to the Grant Finder

Comments

@ClaireValdivia
Copy link
Contributor

Why is this issue important?

Current implementation in staging does not have a way to delete a note, and design did not specify how delete option would appear, so this issue clarifies.

Current State

When you click Edit note, you are able to change the text but not remove the note entirely

Expected State

Updated Prototype: https://www.figma.com/proto/L2gfVMBH0x1daOlOe50sJl/Follow-%2F-Leave-a-Note?page-id=1101%3A13173&node-id=1101-13791&node-type=frame&viewport=1912%2C1374%2C0.48&t=0vDnh8kB4Q8VUrtG-1&scaling=scale-down&content-scaling=fixed&starting-point-node-id=1101%3A13791

When you click "Edit", an overflow menu will appear with two options:

  • Edit
  • Delete (this should display in red text)

Edit should do what the current state of edit is: reformat the text into a text box.
The delete button should remove the text and return the text box to its placeholder state (i.e. what users see before they enter any note)
Deleting a note should not automatically unfollow the grant.

The overflow menu is from the USDR design system - https://www.figma.com/design/HWu4iIjcoX2txuN543qzIB/USDR-Design-System?node-id=668-17022&node-type=canvas&t=EMKqtjUOrXEYevV6-0
The bootstrap dropdown component is the best fit to reference -
https://getbootstrap.com/docs/4.1/components/dropdowns/

Implementation Plan

The following functions need to be added...

Relevant Code Snippets

No response

@ClaireValdivia ClaireValdivia added the Grant Finder Issues related to the Grant Finder label Oct 7, 2024
@greg-adams greg-adams self-assigned this Oct 7, 2024
@ClaireValdivia
Copy link
Contributor Author

This looks great to me!!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Grant Finder Issues related to the Grant Finder
Projects
Status: 🚢 Completed
Development

No branches or pull requests

2 participants