Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Issue]: Adjust login page text #3504

Open
ClaireValdivia opened this issue Sep 13, 2024 · 6 comments
Open

[Issue]: Adjust login page text #3504

ClaireValdivia opened this issue Sep 13, 2024 · 6 comments
Assignees
Labels
good first issue Good for newcomers Grant Finder Issues related to the Grant Finder

Comments

@ClaireValdivia
Copy link
Contributor

ClaireValdivia commented Sep 13, 2024

Why is this issue important?

current "request form" link is broken and there is some confusion from those within NJ of how to request registration

Current State

Image

Expected State

Replace "Don't have account" text on login with the following. This should all display under the login "box". All links should open in a new tab:

Don’t have an account?

Need help? Contact us for support.

Image

See figma file here

Implementation Plan

The following functions need to be added...

Relevant Code Snippets

No response

@ClaireValdivia ClaireValdivia added Grant Finder Issues related to the Grant Finder good first issue Good for newcomers labels Sep 13, 2024
@KorynLA KorynLA self-assigned this Sep 19, 2024
@lsr-explore
Copy link
Contributor

lsr-explore commented Oct 8, 2024

I can take a look at this.

Questions

  • When I follow the links - I see a long form to request access
    • Answer: This is expected - it is the actual link for the state.
  • Should the links urls be used as is?
    • Answer - yes
  • Should all states be shown at the same time or are they shown only for specific instances?
    • Answer - For now, all states will be shown. There are not tenant specific login pages. This is an evolving feature which will be re-evaluated as more states request custom registration forms.
  • Should urls be in configuration files so we don't need to deploy the app if a state needs to change the link to their registration form.
    • Answer - For now, even if feature flags change - a new deploy is done. May evaluate storing in Terraforma (confirm this) configuration.

Initial implementation.
Image

@lsr-explore
Copy link
Contributor

Should this be behind a feature flag?

@ClaireValdivia
Copy link
Contributor Author

@lsr-explore no, this does not need to be behind a feature flag!

@lsr-explore
Copy link
Contributor

@lsr-explore no, this does not need to be behind a feature flag!

Thank you @ClaireValdivia !

@ClaireValdivia
Copy link
Contributor Author

a little behind on my comments from testing, but this looks great in staging and was released earlier this week!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue Good for newcomers Grant Finder Issues related to the Grant Finder
Projects
Status: 🚢 Completed
Development

No branches or pull requests

4 participants