-
Notifications
You must be signed in to change notification settings - Fork 21
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Follow+Notes: Implement note input and note feed on Grant Details view #3428
Comments
@greg-adams Just calling out this addition that I just made to this ticket's implementation notes, per #3407 (comment):
Note that we also need |
* feat: add API to retrieve grant notes for specific user via Finder API - Implemented `getOrganizationNotesForGrantByUser()` function in `grantsCollaboration/notes.js` - Renamed `getOrganizationNotesForGrant()` to `getCurrentNoteRevisions()` and updated signature - Made conditional `WHERE` clause for `grantId` and `userId` in `getCurrentNoteRevisions()` - Created API route `GET /:grantId/notes/user/:userId` in `grants.js` for fetching user-specific grant notes - Added validation for `afterRevision` and `limit` query parameters in the new API - Ensured results are paginated and ordered by `created_at` in descending order - Added necessary imports/exports in `grantsCollaboration/index.js` * ES Lint fixes * ES Lint fixes * ES Lint fixes * ES Lint fixes * ES Lint fixes * first pass * add notes for user * adjust styling * refine grant notes * add FE tests * adjust grant notes * adjust styling * adjust notes display * adjust styling * fix test * extract header text to component * adjust styling * correct limit * remove unused * adjust form validation * use cursor naming * include limit feature flag * limit unbounded row query --------- Co-authored-by: Sushil Rajeeva Bhandary <[email protected]>
So far this is looking really great! per slack discussion, designs are being updated to clarify how delete note should work - I will create a new ticket once that is clarified! |
closing this out as there are no outstanding functionality issues. If we find any bugs or adjustment needed in future bug bashing for this feature, we will open up new issues! |
Subtask of [STORY]: Update 'Status' to 'Follow + Note' feature #2960
Blocked by
Blocks
N/A
Definition of Done
See Figma Designs
GrantNote
component, which displays as the following:editable
slot)GrantNote
component, which displays an "Edit" link.GrantNote
component, none of which display an "Edit" linkImplementation details
followNotesEnabled
feature flag istrue
.getCurrentNoteRevisions()
function defined inpackages/server/src/lib/grantsCollaboration/notes.js
:users.avatar_color as user_avatar_color
to the main database query'sSELECT
statement.SELECT
statement already includesusers.email as user_email
.)user_avatar_color
value of each row in the query result set is mapped tonotes[].user.avatar_color
in the returned object.user_email
value of each row in the query result set is mapped tonotes[].user.email
in the returned object.GrantNote
component.GrantNote
component, so that email addresses are copied to clipboard when clicked.GET /api/organizations/:organizationId/grants/:grantId/notes/:userId
endpoint implemented in Follow+Notes: Retrieve note(s) for grant by a specific user via Finder API #3426, providing a query parameter oflimit=1
.notes
array, this will be the note that was last submitted by the identified user for the identified grant.notes
array, then the identified user has not yet submitted a note for the identified grant.GET /api/organizations/:organizationId/grants/:grantId
route implemented in Follow+Notes: Expose grant notes retrieval in Finder API #3205 supports requests to fetch (paginated) followers of a grant within the same organization as the currently-authenticated user.limit=3
.limit=10
andpaginateFrom={{ fromId }}
, where{{ fromId }}
is the.paginate.from
value provided by the response data in the previous request to this endpoint.PUT /api/organizations/:organizationId/grants/:grantId/notes/revision
endpoint (implemented in Follow+Notes: Expose grant notes creation in Finder API #3204) to save the note.The text was updated successfully, but these errors were encountered: