-
-
Notifications
You must be signed in to change notification settings - Fork 14
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Both arguments of PipeTransport constructor must be file objects #22
Comments
Nah! Getting the most recent dev version from git didn't solve the issue. I think the best way of solving this is creating a function to check using types in python3 or duck typing in python2. Or, we could remove that check from PipeTransport and get rid of the problem - and let an error happen in case no file interface is provided ;) |
Hey guys! I'm using ppft 1.6.6.1 on Python 2.7.12 linux and it's causing me this problem:
Checking around, I discovered the cause. The classes used in gevent for file readers and writers aren't properly detected as file objects. Yet, they are. So the error in transport.py is a bug.
I'm using version 1.6.6.1 installed from pip and noticed that the current code solves the issue.
Is there any deployment to pip of a newer version scheduled?
If so, it's going to save a considerable amount of work on automation scripts.
Anyway, thanks a lot for the project.
It saved us big time to be able to use async in python2 ;)
PS: we are little by little migrating to py3, but it takes lots of time and $$ we don't have right now
The text was updated successfully, but these errors were encountered: