Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

🗑トラベリンクを削除する機能を追加 #200

Open
wants to merge 16 commits into
base: main
Choose a base branch
from
Open

🗑トラベリンクを削除する機能を追加 #200

wants to merge 16 commits into from

Conversation

eve00
Copy link
Contributor

@eve00 eve00 commented Sep 16, 2022

💫 関連Issues

close #196

💪🏻 変更したこと

  • トラベリンクのメニューボタンからモーダルを開く
  • トラベリンクを削除する機能を追加

👀 確認項目

  • 該当ローカルホストの URL
  • http://localhost:3000/home
  • 以下確認してほしい部分のリスト
  • トラベリンクが削除されること

@eve00 eve00 self-assigned this Sep 16, 2022
@k1tikurisu
Copy link
Member

ぎいくてんではいったんstayで

k1tikurisu
k1tikurisu reviewed Jan 25, 2023
View reviewed changes
Copy link
Member

@k1tikurisu k1tikurisu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ちゃんと観てないけど一旦
storybookの修正もお願いします
はやくRTK Query導入したいなーーー

front/src/components/Cards/CardHome.tsx Outdated
<NextLink href={`/${data.id}`} key={data.id} passHref>
<Link
<>
<ModalDeleteTravelknk
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Travelknkになってる！

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

😧

@eve00 eve00 added the Review Required 完了したらこれつける label Jan 25, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@k1tikurisu k1tikurisu k1tikurisu left review comments

@whooolemilk whooolemilk Awaiting requested review from whooolemilk

At least 1 approving review is required to merge this pull request.

Assignees

@eve00 eve00

Labels
Logic Markup Review Required 完了したらこれつける
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

トラベリンクを削除する機能
2 participants
@eve00 @k1tikurisu