-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Apply latest updates from CRA upstream (minus warning) #5
Comments
What's the diff between this fork and upstream? Looks like it's mostly just fixing the deps issue, typescript fixes and node-sass fixes (which would be good to upstream)? Would you be interested in helping to maintain create-react-app directly instead of maintaining the fork? |
I think our original motivation was to add pnpm support for students with slower machines, but then since we had a chance to fix some DX things, we:
The reason why I didn't contribute back was lack of response when I was contributing fixes before (and the publicly-announced deprecation):
But I would be interested in helping to maintain projects which are important to the React team, if CRA is still that. Why not just switch to Vite? Because it was not a drop-in replacement and we wanted to devote any effort to a bigger curriculum switch from |
So once your course materials move from cra to nextjs this fork will also be deprecated? |
Right, that sounds correct. |
New version of CRA will be released today, including a deprecation notice (facebook#17003):
It also includes some other changes and fixes which will modernize some things, as mentioned in facebook#13725:
We should apply the latest changes from upstream, so that we can keep our
@upleveled/create-react-app
fork alive as long as possible.The text was updated successfully, but these errors were encountered: