Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Apply latest updates from CRA upstream (minus warning) #5

Open
karlhorky opened this issue Jan 29, 2025 · 4 comments
Open

Apply latest updates from CRA upstream (minus warning) #5

karlhorky opened this issue Jan 29, 2025 · 4 comments
Assignees

Comments

@karlhorky
Copy link
Member

karlhorky commented Jan 29, 2025

New version of CRA will be released today, including a deprecation notice (facebook#17003):

It also includes some other changes and fixes which will modernize some things, as mentioned in facebook#13725:

Merging this PR could come with #13725 and it should get green and give CRA a bit of a longer run

We should apply the latest changes from upstream, so that we can keep our @upleveled/create-react-app fork alive as long as possible.

@karlhorky karlhorky self-assigned this Jan 29, 2025
@rickhanlonii
Copy link

What's the diff between this fork and upstream? Looks like it's mostly just fixing the deps issue, typescript fixes and node-sass fixes (which would be good to upstream)? Would you be interested in helping to maintain create-react-app directly instead of maintaining the fork?

@karlhorky
Copy link
Member Author

karlhorky commented Jan 29, 2025

I think our original motivation was to add pnpm support for students with slower machines, but then since we had a chance to fix some DX things, we:

  1. Upgraded some deps including the TypeScript
  2. Added Sass by default for CSS modules
  3. Allowing for ESM with "type": "module"
  4. Fixed some other things which were causing a workflow problems for students eg. deploying to Netlify or ESLint errors with Jest, etc

The reason why I didn't contribute back was lack of response when I was contributing fixes before (and the publicly-announced deprecation):

But I would be interested in helping to maintain projects which are important to the React team, if CRA is still that.


Why not just switch to Vite? Because it was not a drop-in replacement and we wanted to devote any effort to a bigger curriculum switch from create-react-app to Next.js:

@DogPawHat
Copy link

So once your course materials move from cra to nextjs this fork will also be deprecated?

@karlhorky
Copy link
Member Author

Right, that sounds correct.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants