Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Some GraphQL queries are inefficient #12

Closed
stefanolsen opened this issue Sep 2, 2023 · 3 comments · Fixed by #15 · May be fixed by #13
Closed

Some GraphQL queries are inefficient #12

stefanolsen opened this issue Sep 2, 2023 · 3 comments · Fixed by #15 · May be fixed by #13

Comments

@stefanolsen
Copy link
Collaborator

A client of mine is looking into using this add-on. During testing, I have found some queries to be slow and wrote some changes.

However, I am missing push access to push a feature branch in order to make a PR.
@andrewmarkham
Copy link
Collaborator

Hi @stefanolsen

You should have write access now.

@stefanolsen
Copy link
Collaborator Author

Added a PR #13 to remove the audience count queries.

@stefanolsen stefanolsen reopened this Sep 3, 2023
@stefanolsen stefanolsen linked a pull request Sep 3, 2023 that will close this issue
Embed audience count in first query, and remove subsequent queries #13
Open
@andrewmarkham
Copy link
Collaborator

Hi @stefanolsen

I am going to pass this over to @davidknipe to take a look at. The approach you have just taken out was put in place to handle some timeout/performance issues when there was a lot of Real Time Segments. I just want to ensure that we are not reverting back to that behaviour with your PR.

Thanks

@stefanolsen stefanolsen linked a pull request Sep 4, 2023 that will close this issue
Remove the dynamic customer query #15
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
2 participants
@stefanolsen @andrewmarkham