Fix screen readers announcing toasts #1551
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aria-atomic attribute specifically needs the "true" value to be read by screen readers, and VoiceOver requires the role "alert" for some reason
zernonia
approved these changes
Jan 14, 2025
There was a problem hiding this comment.
Thanks for the PR @nicooprat ! Tested locally and it seems good! Yeah announceTextContent was designed to be an array.
The aria-label for ToastViewport will be focused and announced when we use the hotkey (default F8) to navigate to the region
commit: |
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I'm currently fixing accessibility for our app and migrating to Radix. I struggled to make screen readers announce toasts and I think I found the culprit.
aria-atomicattribute specifically needs thetruevalue to be read by screen readers, and VoiceOver requires theroleto be set asalertfor some reason.Also,
announceTextContentseems to display content as an array which is weird when it's announced:VoiceOver:
NVDA:
It's done on purpose (cf. https://github.com/unovue/radix-vue/blob/main/packages/radix-vue/src/Toast/utils.ts#L77-L78) but VoiceOver actually reads
"3"asthree inchesfor instance, because in our case we have astrongelement on the number but there's no reason to make a pause between those words.Setup:
Also I couldn't make screen readers read the
labelprop from theToastViewportcomponent, I'm not sure if it's expected.In conclusion the proposed fix makes the component work at least in my tests, even if there's still room for improvement IMO.
Let me know what you think!