Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug]: Internal state wasn't respecting the provided value (open/modelValue/checked) #446

Closed
zernonia opened this issue Oct 7, 2023 · 0 comments · Fixed by #436
Closed
Assignees
Labels
bug Something isn't working

Comments

@zernonia
Copy link
Member

zernonia commented Oct 7, 2023

Environment

Radix Vue version: 0.4.1

Link to minimal reproduction

https://codesandbox.io/p/sandbox/radix-vue-popover-forked-jygwzg?file=%2Fsrc%2FApp.vue%3A11%2C11

Steps to reproduce

Clicking on PopoverTrigger in radix-vue updates internal state regardless of what's the value of open prop. Please compare these 2 examples:

Describe the bug

Clicking on "Externally Controlled" will work as expected in both and will toggle content properly.
Clicking on "PopoverTrigger" differs. in radix-vue it will keep toggling the Content of Popover. In radix-ui Content will respect open value and won't toggle.

Expected behavior

It should be the same behaviour as radix-ui

Conext & Screenshots (if applicable)

No response

@zernonia zernonia added the bug Something isn't working label Oct 7, 2023
@zernonia zernonia self-assigned this Oct 7, 2023
@zernonia zernonia linked a pull request Oct 7, 2023 that will close this issue
Merged
5 tasks
@zernonia zernonia mentioned this issue Oct 10, 2023
Merged
5 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant