Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

EmbeddedSource is using AddEnvironmentConfiguration instead AddEnvironmentEmbeddedConfiguration #2681

Open
3 of 16 tasks
chrisdreams13 opened this issue Jan 30, 2025 · 0 comments
Labels
kind/bug Something isn't working triage/untriaged Indicates an issue requires triaging or verification.

Comments

@chrisdreams13
Copy link

Current behavior

EmbeddedSource functions is using AddEnvironmentConfiguration when a config is provided in params

Expected behavior

EmbeddedSource functions should use AddEnvironmentEmbeddedConfiguration as all 3 AddConfigurtations in function

How to reproduce it (as minimally and precisely as possible)

public static IConfigBuilder EmbeddedSource<TApplicationRoot>(this IConfigBuilder hostBuilder, string? config = null, bool includeEnvironmentSettings = true)
	where TApplicationRoot : class
{
	return hostBuilder
			.ConfigureAppConfiguration((ctx, b) =>
			{
				if (config is { Length: > 0 })
				{
					b.AddEmbeddedConfiguration<TApplicationRoot>(ctx, config);
					if (includeEnvironmentSettings)
					{
						b.AddEnvironmentConfiguration(ctx, config); <----- here
					}
				...

Environment

Nuget Package: Uno.Extensions.Configuration

Package Version(s): 5.2.7

Affected platform(s):

  • iOS
  • macOS (AppKit)
  • Mac Catalyst
  • Android
  • WebAssembly
  • Windows
  • Skia (WPF)
  • Skia (GTK on Linux/macOS/Windows)
  • Skia (Linux Framebuffer)
  • Build tasks

Visual Studio:

  • 2019 (version: )
  • 2022 (version: )
  • Visual Studio Code (version: )
  • Rider Windows (version: )
  • Rider macOS (version: )

Relevant plugins:

  • Resharper (version: ) 2024.3.4
@chrisdreams13 chrisdreams13 added kind/bug Something isn't working triage/untriaged Indicates an issue requires triaging or verification. labels Jan 30, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/bug Something isn't working triage/untriaged Indicates an issue requires triaging or verification.
Projects
None yet
Development

No branches or pull requests

1 participant