data property in directories is not undefined

[ayuhito]

Environment

Node.js 18
nanotar: 0.1.1

Reproduction

nanotar/test/index.test.ts

Line 58 in c1247bd

"data": "<hidden>",

That may be unique to how the test was made, but otherwise you'll still get a defined empty Uint8Array. e.g.

Describe the bug

The documentation states:

data field is optional for directories and can be either a String, ArrayBuffer or Uint8Array.

I would have assumed a directory check could be done with if (file.data) but that isn't the case (including the JSDoc comments which states "file data (don't provide for directories)".

Instead it is if (file.data && file.data.length > 0) since the type for data is still marked as nullable but will send an empty array instead.

Additionally:

Parsed files array has two additional properties: size file size and text, a lazy getter that decodes data view as a string.

nanotar/src/parse.ts

Line 3 in c1247bd

export function parseTar(data: ArrayBuffer | Uint8Array): TarFileItem[] {

The parse functions return TarFileItem[] instead of ParsedTarFileItem[] which makes the TypeScript compiler believe these should be inaccessible. I'm not sure if these are intentionally inaccessible, but I think relying on file.type === 'directory' and file.type === 'file' is far more intuitive for differentiating these types.

---

I didn't make a PR since I think there are multiple API inconsistencies, so it might make sense to get a clear answer from a maintainer before making a change. Whether it is just an invalid property error, type error, or both.

Thanks for the awesome library!

Additional context

No response

Logs

No response