Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Font files not copied to Android assets folder if they are already correctly noted in the link-assets-manifest.json file #59

Open
teststation5 opened this issue Oct 23, 2023 · 1 comment

Comments

@teststation5
Copy link

in a react-native project where gitignore is purposely ignoring all files in the android\app\src\main\assets folder, but the link-assets-manifest.json file is in source control. Someone building the project on a new machine will use the react-native-asset command line but the asset files will not be copied to the android\app\src\main\assets folder because the link-assets-manifest.json file is up to date. The assets will not be available on the Android device and it can take many, many hours to figure out why.

Suggested improvement would be to check both if the asset file exists in the link-assets-manifest.json file and also if it physically exists in the android\app\src\main\assets folder and copy it there if not.

@1uss1
Copy link

1uss1 commented Dec 21, 2023

I agree with your suggestion. I encountered the same issue in my project and my solution for it was to add the link-assets-manifest.json files into gitignore.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants