Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

lua/Makefile.uk: Bump version to 5.4.4 #4

Closed
wants to merge 1 commit into from

Conversation

jalil-salame
Copy link
Contributor

Tested under x86_64, runs in linuxu and kvm using the lua app

Signed-off-by: Jalil David Salamé Messina [email protected]

@razvand razvand linked an issue Oct 23, 2022 that may be closed by this pull request
@razvand razvand self-assigned this Oct 23, 2022
@razvand razvand added enhancement New feature or request kind/hackathon Hackathon challenge labels Oct 23, 2022
@razvand
Copy link
Contributor

razvand commented Oct 23, 2022

@salameme , 30 points awarded, will check to see if it's upstreamable.

Copy link
Contributor

@razvand razvand left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, @salameme . For the commit message, please say "using the Lua app in the app-lua repository." Use backticks around app-lua and end it dot.

Tested under x86_64, runs in `linuxu` and `kvm` using the Lua app in the
`app-lua` repository.

Signed-off-by: Jalil David Salamé Messina <[email protected]>
@jalil-salame
Copy link
Contributor Author

Thanks, @salameme . For the commit message, please say "using the Lua app in the app-lua repository." Use backticks around app-lua and end it dot.

Fixed

@razvand razvand self-requested a review October 23, 2022 15:34
Copy link
Contributor

@razvand razvand left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, @salameme

Reviewed-by: Razvan Deaconescu [email protected]
Approved-by: Razvan Deaconescu [email protected]

@razvand
Copy link
Contributor

razvand commented Oct 23, 2022

@salameme , 30 more points for the approval.

@jalil-salame jalil-salame deleted the bump-5.4.4 branch February 28, 2024 06:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ci/merged enhancement New feature or request kind/hackathon Hackathon challenge
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

Update version to 5.4.4
3 participants