Circular dependencies if adding libunwind as dependency #8
Conversation
|
regarding #4 |
DeliaPavel
force-pushed
the
staging
branch
2 times, most recently
from
2bcc56e to
ce4bd23
Compare
There was a problem hiding this comment.
See my comment. I tested it and with the Config.uk contents below, it works:
menuconfig LIBCOMPILER_RT
bool "compiler-rt - runtime support"
select LIBPOSIX_SYSINFO
select LIBUKMMAP
depends on LIBUNWIND
default n
if LIBCOMPILER_RT
config LIBCOMPILER_RT_ATOMIC
bool "Implementation of an atomics library"
select CXX_THREADS
default N
endif
I user app-helloworld-cpp to test.
DeliaPavel
force-pushed
the
staging
branch
2 times, most recently
from
1bd5bf3 to
e613b45
Compare
razvand
added
enhancement
There was a problem hiding this comment.
@DeliaPavel , together with @StefanJum we did a thorough analysis of the dependencies. This should be fixed. lib-compiler-rt depends on lib-libunwind. select LIBUNWIND should be part of this. And select COMPILER_RT needs to be removed from the Config.uk file for lib-libunwind.
The |
Signed-off-by: Delia-Maria Pavel <[email protected]>
There was a problem hiding this comment.
Thanks, @DeliaPavel .
Reviewed-by: Razvan Deaconescu [email protected]
Approved-by: Razvan Deaconescu [email protected]
libunwind already specifies compiler-rt as a dependency in its Config.uk. If we would add libunwind as a dependency in compiler-rt's Config.uk we would receive an error because there would be a circular dependency.
Signed-off-by: Delia-Maria Pavel [email protected]