Makefile.uk: Don't add unsupported warnings when built with clang #10
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hackathon points: 20 |
StefanJum
suggested changes
May 4, 2023
There was a problem hiding this comment.
Thank you @iAmGroute, besides the comments. please also add a short description to the commit message.
|
@iAmGroute, could you please take care of the comments above? |
|
Hi @StefanJum, sorry for the delay. For reference, when built:
I've tested the above with GCC and Clang, it's as expected: Versions: |
StefanJum
suggested changes
Jun 18, 2023
There was a problem hiding this comment.
Hi @iAmGroute, please wrap your commit message at ~72 characters.
Also it looks like there are some conflicts, so please rebase it. We can merge it after that.
Clang (12.0.0) does not recognize the warnings: no-unused-but-set-variable no-maybe-uninitialized no-builtin-declaration-mismatch It would print "unknown warning option" warning messages. These should be enabled only with GCC (tested with 11.3.0). GitHub-Fixes: unikraft#1 Co-authored-by: Nikos Oikonomou <[email protected]> Signed-off-by: Nikos Oikonomou <[email protected]> Signed-off-by: Groute <[email protected]>
|
Should be OK now. |
StefanJum
approved these changes
Jun 20, 2023
There was a problem hiding this comment.
All good now, thanks.
Reviewed-by: Stefan Jumarea [email protected]
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Part of the hackathon challenges, Fixes: #1
I couldn't reproduce the original issue with
-Wno-unused-but-set-variable -Wno-maybe-uninitialized, but verified with-Wno-builtin-declaration-mismatch.Authored by @Se7enBit, I'm just doing the commit/PR :)