Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Detect if make or gmake should be used (Darwin) #742

Closed
skuenzer opened this issue Aug 24, 2023 · 1 comment
Closed

Detect if make or gmake should be used (Darwin) #742

skuenzer opened this issue Aug 24, 2023 · 1 comment
Labels
kind/enhancement New feature or request

Comments

@skuenzer
Copy link
Member

Feature request summary

When running on Mac and having dependencies installed via brew, as default, brew's make version is installed via gmake. This is done to avoid conflicts with the Apple-shipped make version. If a user does not replace Apple's make, kraft build won't work at the moment:

Example:

$ kraft build --kraftfile kraft.cloud.yaml --no-cache -j 4
[+] updating package index                                                                                                                                 [0.7s]
[+] finding core/unikraft:cloud                                                                                                                            [1.4s]
[+] finding lib/nginx:stable                                                                                                                               [1.1s]
[+] finding lib/ukp-bin:stable                                                                                                                             [1.9s]
[+] finding lib/musl:stable                                                                                                                                [1.3s]
[+] finding lib/lwip:stable                                                                                                                                [1.4s]
[+] pulling lib/nginx:stable                  ••••••••••••••••••••••••••••••••••••••••••••••••••••••••••••••••••••••••••••••••••••••••••••••••••••••• 100% [0.9s]
[+] pulling lib/musl:stable                   ••••••••••••••••••••••••••••••••••••••••••••••••••••••••••••••••••••••••••••••••••••••••••••••••••••••• 100% [0.6s]
[+] pulling core/unikraft:cloud               ••••••••••••••••••••••••••••••••••••••••••••••••••••••••••••••••••••••••••••••••••••••••••••••••••••••• 100% [1.4s]
[+] pulling lib/lwip:stable                   ••••••••••••••••••••••••••••••••••••••••••••••••••••••••••••••••••••••••••••••••••••••••••••••••••••••• 100% [1.0s]
[+] pulling lib/ukp-bin:stable                ••••••••••••••••••••••••••••••••••••••••••••••••••••••••••••••••••••••••••••••••••••••••••••••••••••••• 100% [0.7s]
<!> configuring kraftcloud-x86_64 (fc/x86_64)                                                                                                           0% [0.0s]
 E  Makefile:64: *** We need GNU make >= 4.1. It can be installed with 'brew install make'. Retry with: 'gmake /Users/skuenzer/Workspace/...'

[ ] building kraftcloud-x86_64 (fc/x86_64)                                                                                                              0% [0.0s]
exit status 2

This issue is also related to issue #674

Describe alternatives

No response

Related architectures

None

Related platforms

None

Additional context

No response

@skuenzer skuenzer added the kind/enhancement New feature or request label Aug 24, 2023
@github-project-automation github-project-automation bot moved this to 🧊 Icebox in KraftKit Roadmap Aug 24, 2023
@jake-ciolek
Copy link
Contributor

This has been fixed in #744

@github-project-automation github-project-automation bot moved this from 🧊 Icebox to 🚀 Done in KraftKit Roadmap Aug 29, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/enhancement New feature or request
Projects
Status: 🚀 Done
Development

No branches or pull requests

2 participants