You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
On these lines components of vectors r_ are used explicitly, meaning that libAcoustics is sticked to specific frame of reference. I think, that should be avoided, because we don't know in advance what frame of reference will be used by the library users.
The text was updated successfully, but these errors were encountered:
mkraposhin
changed the title
Possible invariance to frame of references
Possible dependence to frame of references
Dec 18, 2023
In file fwhFormulation.C I found next lines:
libAcoustics/Sources/lib/analogies/FfowcsWilliamsHawkings/fwhFormulation.C
Line 73 in b9cd1d6
libAcoustics/Sources/lib/analogies/FfowcsWilliamsHawkings/fwhFormulation.C
Line 76 in b9cd1d6
On these lines components of vectors r_ are used explicitly, meaning that libAcoustics is sticked to specific frame of reference. I think, that should be avoided, because we don't know in advance what frame of reference will be used by the library users.
The text was updated successfully, but these errors were encountered: