Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

sourceType 'module' is not supported when ecmaVersion < 2015 #185

Closed
vladshcherbin opened this issue Nov 15, 2024 · 4 comments · May be fixed by #186
Closed

sourceType 'module' is not supported when ecmaVersion < 2015 #185

vladshcherbin opened this issue Nov 15, 2024 · 4 comments · May be fixed by #186

Comments

@vladshcherbin
Copy link

vladshcherbin commented Nov 15, 2024 •
edited
Loading

Hey 👋

I for the love of god can't understand what's this error. Even the simplest config gives it:

import js from '@eslint/js'
import eslintPluginImportX from 'eslint-plugin-import-x'

export default [
  js.configs.recommended,
  eslintPluginImportX.flatConfigs.recommended,
  {
    rules: {
      'comma-dangle': ['error', 'never'],
      'semi': ['error', 'never']
    }
  }
]

I've tried different setting configurations and language options with no luck.

image

node - 22.10.0
eslint - 9.15.0
eslint-plugin-import-x - 4.4.2

reproduction - https://github.com/vladshcherbin/eslint-import
script - pnpm lint or pnpm eslint
@SukkaW
Copy link
Collaborator

SukkaW commented Nov 16, 2024

@vladshcherbin I will look into this! I suspect #181 is related.

@huynhducduy
Copy link

Some other packages that I find having the same issue:

@eslint-react/[email protected]
@tanstack/[email protected]
[email protected]
[email protected]
[email protected]
[email protected]
[email protected]
[email protected]

SukkaW added a commit to SukkaW/eslint-plugin-import-x that referenced this issue Nov 19, 2024
@SukkaW
fix(un-ts#185): add langaugeOptions.parserOptions to flat preset
9d32264
SukkaW added a commit to SukkaW/eslint-plugin-import-x that referenced this issue Nov 19, 2024
@SukkaW
fix(un-ts#185): update sourceType utils
a4c246d
@SukkaW SukkaW mentioned this issue Nov 19, 2024
Draft
@SukkaW
Copy link
Collaborator

SukkaW commented Nov 19, 2024

cc @vladshcherbin @huynhducduy

I have created a PR #186 to fix the issue!

@SukkaW SukkaW mentioned this issue Nov 20, 2024
Merged
SukkaW added a commit that referenced this issue Nov 20, 2024
@SukkaW
fix(#185): merge parserOptions from langaugeOptions (#187)
a428f82
@SukkaW SukkaW mentioned this issue Nov 20, 2024
Merged
@SukkaW
Copy link
Collaborator

SukkaW commented Nov 20, 2024

Fixed by #187

@SukkaW SukkaW closed this as completed Nov 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
3 participants
@vladshcherbin @huynhducduy @SukkaW