twig dump

[ajakov]

Hi @umutphp

Can this action check for dump in twig files?

Like, for example:
{{ dump() }}
or
{{ dump(variable) }}

[umutphp]

Hi @ajakov ,

Yes, you need to use checktype: 'symfony'.

You can configure as follows;

on: [push]

jobs:
  var_dump_checker:
    runs-on: ubuntu-latest
    name: Dump Function Checks
    steps:
    - name: Check 1
      id: check1
      uses: umutphp/php-var-dump-check-action@v1
      with:
        checktype: 'symfony'
        exclude: 'vendor,test'
        extensions: 'php'

[umutphp]

@ajakov
Can you please check and update me?

[ajakov]

Thank you for your quick response.
That is exactly what I tried.
Unfortunately, looks like the tool used in this action does not support it: https://github.com/php-parallel-lint/PHP-Var-Dump-Check

I installed it also locally (to dismiss the possibility that my github actions configuration is wrong) and it doesn't detect dump in twig files.

[umutphp]

What is the extension for your twig files? If it is other than "php", please try adding it to extensions parameter.

[ajakov]

Yes, I added that, too.

[umutphp]

I found an issue which was created in the former repository (JakubOnderka/PHP-Var-Dump-Check) and It seems it is not implemented :(.

[ajakov]

Exactly.
At least now we know where to look. Maybe it's not too complicated to add it.

[umutphp]

If you create the issue in the new repo, I will also comment to promote it.

PS: I am not sure If l have time to contribute to fix the issue, but I will try if I have :)

[ajakov]

I will check the codebase, but on the first glance it looks the tool is made exclusively for PHP, since it uses token_get_all and then checks against the results of it.

So, maybe using different tool for checking twig is better in this case. I will double-check when I have more time.

[umutphp]

Please, do not forget to update me :)

[ajakov]

Hey @umutphp, I published this in the meantime: https://github.com/ajakov/twig-dump-checker

[umutphp]

Hi @ajakov,

Great news :).

PS: The link is wrong in your comment is wrong by the way.

[ajakov]

Fixed the link, thank you! :)