Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Editing soruce code for Tiptap RTE doesn't work #17832

Open
stefanstankovic opened this issue Dec 17, 2024 · 2 comments
Open

Editing soruce code for Tiptap RTE doesn't work #17832

stefanstankovic opened this issue Dec 17, 2024 · 2 comments

Comments

@stefanstankovic
Copy link

Which Umbraco version are you using? (Please write the exact version, example: 10.1.0)

15.1.1

Bug summary

I'm trying to replace TinyMCE in my project with a new solution Tiptap. First I want to test it so I created a new DataType for RTE that uses Tiptap.

I put an example text in the RTE that has a Heading and 3 paragraphs and published it. Then I tried to add a custom CSS class to the Heading directly in the source code. Opening the source code works and I can write the custom class, but after submitting the content and saving the class disappeared.

Specifics

No response

Steps to reproduce

  1. Create a new Data Type for RTE by using Tiptap
  2. Create a new Element Document Type with a property that will use the new Data Type
  3. Create another Element type that will represent the layout in the Block Grid
  4. Create a new Data Type for the Block grid
  5. Add elements from steps 2 and 3 in the Grid and allow the element from step 3 to be added in the root and the element from step 2 to be added as part of element 3.
  6. Create a Content page type that has the Block Grid and can be added to the root
  7. Create a new Content page by using the Content page type created in step 5 and add the layout element and the element with Tiptap.
  8. Add some content in the RTE and save it
  9. Try to edit the source code

Editis source code doesn't work. You can change and submit changes but they won't be saved

Expected result / actual result

No response

Copy link

Hi there @stefanstankovic!

Firstly, a big thank you for raising this issue. Every piece of feedback we receive helps us to make Umbraco better.

We really appreciate your patience while we wait for our team to have a look at this but we wanted to let you know that we see this and share with you the plan for what comes next.

  • We'll assess whether this issue relates to something that has already been fixed in a later version of the release that it has been raised for.
  • If it's a bug, is it related to a release that we are actively supporting or is it related to a release that's in the end-of-life or security-only phase?
  • We'll replicate the issue to ensure that the problem is as described.
  • We'll decide whether the behavior is an issue or if the behavior is intended.

We wish we could work with everyone directly and assess your issue immediately but we're in the fortunate position of having lots of contributions to work with and only a few humans who are able to do it. We are making progress though and in the meantime, we will keep you in the loop and let you know when we have any questions.

Thanks, from your friendly Umbraco GitHub bot 🤖 🙂

@NguyenThuyLan
Copy link
Contributor

Thank you @stefanstankovic for reporting this issue.
I was able to reproduce it on v15.1.1, it is not able to add class or id into the HTML tag by editing source code mode using Tiptap RTE, after clicking submit, it is removed from the HTML tag.
Short steps to reproduce :

  1. Create a document type with Tiptap RTE
  2. Create a content page and add a text string to the RTE
  3. Click Edit source code of RTE, add a custom class/id into the HTML tag, then click submit
  4. Open Edit source of RTE again, => custom class/id added is disappear

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants