-
Notifications
You must be signed in to change notification settings - Fork 2.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Changing the order in the repeatable strings isn't saved #16884
Comments
Hi there @mdeslauriers-sigmund! Firstly, a big thank you for raising this issue. Every piece of feedback we receive helps us to make Umbraco better. We really appreciate your patience while we wait for our team to have a look at this but we wanted to let you know that we see this and share with you the plan for what comes next.
We wish we could work with everyone directly and assess your issue immediately but we're in the fortunate position of having lots of contributions to work with and only a few humans who are able to do it. We are making progress though and in the meantime, we will keep you in the loop and let you know when we have any questions. Thanks, from your friendly Umbraco GitHub bot 🤖 🙂 |
Thank @mdeslauriers-sigmund for reporting this issue. |
This issue does occur in 13.4.1 |
Which Umbraco version are you using? (Please write the exact version, example: 10.1.0)
14.1.1
Bug summary
In the property-editor "Multiple reapeatable strings" when you change the order of existing entries, no change event is dispatched and the changes aren't saved.
Specifics
The problem occurs in
Umbraco.CMS.Backoffice\src\packages\core\components\multiple-text-string-input\input-multiple-text-string.element.ts
In the configuration of the
#sorter
there is the following code :There should be a call to
this.dispatchEvent(new UmbChangeEvent());
at the end of theonChange
method to notify the parent property-editor that there is a new sort order. (dispatchEvent
is called for all other changes in the component)Btw, the
identifier
could be renamed to something like'Umb.SorterIdentifier.InputMultipleTextString'
, it seems like a copy/paste from another file (multiple-color-picker-input.element.ts
).Steps to reproduce
Result : the change wasn't saved
Expected result / actual result
Changing the order and saving should be persisted, event if no strings are modified
The text was updated successfully, but these errors were encountered: