-
-
Notifications
You must be signed in to change notification settings - Fork 36
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix coreml issues in macos15 ios restricted #81
Conversation
All Contributors have signed the CLA. ✅ |
👋 Hello @picsalex, thank you for submitting a PR to
If this PR introduces new functionality or significantly modifies existing behavior, please also confirm you’ve included a minimum reproducible example (MRE) to demonstrate the changes. This is especially critical for testing any CoreML engine or inference modifications in the PR. For additional guidance on contributing to this repository, please check our Contributing Guide. Don't hesitate to ask any questions or comment if you need further assistance. 🚀 Thank you again for your submission! One of our Ultralytics engineers will review your PR soon. 😊 |
I have read the CLA Document and I sign the CLA |
@john-rocky let's get this reviewed please! Thank you. |
@picsalex Great work. This works. Thanks for the comprehensive research including pre-iOS16. |
🎉 Big thanks and congratulations on the successful merge of #81, @picsalex, with valuable contributions from @glenn-jocher and @john-rocky! 🚀 Your collaboration and dedication to improving the YOLO iOS app are truly inspiring. As Henry Ford once said, "Coming together is a beginning, staying together is progress, and working together is success." This PR is a perfect example of brilliant minds coming together to make something even better! 🌟 The clarified model requirements, detailed export instructions, and innovative E5 ML engine optimization are game-changers for both developers and users. Your work helps pave the way for a smoother, faster, and more user-friendly experience.👏 Thank you for your passion, ingenuity, and commitment—you're making a real impact! 💡✨ |
This fix addresses a bug affecting trained models on macOS 15, which caused incorrect results during the inferences. By disabling experimentalMLE5EngineUsage in MLModelConfiguration, trained models will function normally. Note that this modification is only available for iOS 17 and later versions. The
README.md
has been updated accordingly.🛠️ PR Summary
Made with ❤️ by Ultralytics Actions
🌟 Summary
Updated the YOLO iOS app to clarify model requirements and optimize model performance for iOS 17 devices. 🚀
📊 Key Changes
ViewController.swift
by introducing an experimental E5 ML engine optimization for iOS 17 to improve performance. ✨🎯 Purpose & Impact
Overall, this improves both usability and efficiency for developers and end-users of the YOLO iOS app! 🛠👩💻