Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a new reactor that includes options for ports #594

Open
shimwell opened this issue Nov 29, 2020 · 4 comments · May be fixed by #717
Open

Add a new reactor that includes options for ports #594

shimwell opened this issue Nov 29, 2020 · 4 comments · May be fixed by #717
Assignees
Labels
enhancement New feature or request

Comments

@shimwell
Copy link
Collaborator

shimwell commented Nov 29, 2020

The impact of ports on the TBR is a common request for parameter studies. Perhaps we can add another reactor based on the ball reactor that allows port to be placed. Perhaps we could we use the port_cutters_rectangular component

additional arguments
number of ports
width: list of floats
height: list of floats
fillet size: list of floats
port azimuthal angles: list of floats

in the event that the users does not provide the port azimuthal angles then these can be calculated by spearing them out equally. In a more realistic case they should be placed so that they line up with the gaps in the TF coils

@billingsley-john billingsley-john self-assigned this Nov 30, 2020
@RemDelaporteMathurin
Copy link

Should it be a new reactor or an adaptation of the existing ones ?

@billingsley-john
Copy link

For ease, a new reactor based on the ball_reactor will be created first to understand the logic, then perhaps in the future the existing reactors could be adapted to include ports? However, I wouldn't be opposed to keeping completely separate reactors with and without ports, i.e. BallReactor and BallReactorWithPorts

@RemDelaporteMathurin
Copy link

Yep you are right :-)

It's just that in the future it might get complex with BallReactorWithPorts, SingleNullBallReactorWithPorts, SingleNullBallReactorWithPortsWithDTFCoils, etc.. haha

But it's okay for now I guess

@shimwell
Copy link
Collaborator Author

Yep the number of reactors could really increase with all these options. This table idea can help us know what is available #424

We might need to change the naming scheme so that all he combinations can be supported without having really long names :-)

@RemDelaporteMathurin RemDelaporteMathurin added the enhancement New feature or request label Feb 10, 2021
@billingsley-john billingsley-john linked a pull request Feb 19, 2021 that will close this issue
10 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants