Skip to content

Commit 19f2574

Browse files
committed
fixed checks for pull requests
1 parent bf558aa commit 19f2574

File tree

1 file changed

+8
-8
lines changed

1 file changed

+8
-8
lines changed

.github/workflows/frontend_checks.yml

Lines changed: 8 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -19,6 +19,8 @@ jobs:
1919
COMPOSE_PROFILES: "weaviate,ray,background,backend,frontend"
2020
RAY_CONFIG: "config_gpu.yaml"
2121
JWT_SECRET: ${{ secrets.JWT_SECRET }}
22+
BACKEND_HAS_NEW_REQUIREMENTS: false
23+
RAY_HAS_NEW_REQUIREMENTS: false
2224
steps:
2325
- uses: actions/checkout@v3
2426
- name: Checkout PR
@@ -28,21 +30,19 @@ jobs:
2830
run: gh pr checkout ${{ github.event.pull_request.number }}
2931
- name: Check for new backend requirements
3032
id: check_backend_requirements
33+
if: github.event_name == 'pull_request'
3134
run: |
32-
if git diff --name-only ${{ github.event.before }} ${{ github.sha }} | grep -q -e '^backend/requirements.txt' -e '^backend/environment.yml'; then
33-
echo "Backend has new requirements"
35+
base_branch=$(git merge-base origin/${{ github.event.pull_request.base.ref }} HEAD)
36+
if git diff --name-only $base_branch HEAD | grep -q -e '^backend/requirements.txt' -e '^backend/environment.yml'; then
3437
echo "BACKEND_HAS_NEW_REQUIREMENTS=true" >> $GITHUB_ENV
35-
else
36-
echo "BACKEND_HAS_NEW_REQUIREMENTS=false" >> $GITHUB_ENV
3738
fi
3839
- name: Check for new ray requirements
3940
id: check_ray_requirements
41+
if: github.event_name == 'pull_request'
4042
run: |
41-
if git diff --name-only ${{ github.event.before }} ${{ github.sha }} | grep -q -e '^backend/src/app/preprocessing/ray_model_worker/requirements.txt'; then
42-
echo "Ray has new requirements"
43+
base_branch=$(git merge-base origin/${{ github.event.pull_request.base.ref }} HEAD)
44+
if git diff --name-only $base_branch HEAD | grep -q -e '^backend/src/app/preprocessing/ray_model_worker/requirements.txt'; then
4345
echo "RAY_HAS_NEW_REQUIREMENTS=true" >> $GITHUB_ENV
44-
else
45-
echo "RAY_HAS_NEW_REQUIREMENTS=false" >> $GITHUB_ENV
4646
fi
4747
- name: Prepare environment
4848
run: |

0 commit comments

Comments
 (0)