Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Nice working code, but I have some questions #9

Open
MWL91 opened this issue May 8, 2022 · 0 comments
Open

Nice working code, but I have some questions #9

MWL91 opened this issue May 8, 2022 · 0 comments

Comments

@MWL91
Copy link

MWL91 commented May 8, 2022

Hello.

First of all, I would like to say, that your code looks good, and I like it.
I would like to make some addition and create a pull request, but before I do it I want to ask a few questions:

  • I see, that minimum requested PHP version is 5.3, which doesn't support strict types. I would like to add to each method return type, and to each parameter type, but then the PHP version should be upgraded - is that ok for you?
  • I see, that some places are not valid with PSR. Do you mind to reformat your code a little bit?
  • You are using nette tester for tests. Why not PHPUnit? Is it a reason for that? If not, do you mind to rewrite all tests to PHPUnit?
  • I would like to write a simpler way to retrieve a solution (for now as I see in tests, we have to perform some foreach to find the answer). Is that ok for you, or do you see some issues here?
  • After all, I would like to create a wrapper for Laravel (just to let you know).
This was referenced May 8, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant