Skip to content
This repository has been archived by the owner on Apr 11, 2023. It is now read-only.

Not possible to follow some links using "f" in certain sites #238

Open
1 of 2 tasks
marvinbelfort opened this issue Nov 23, 2017 · 8 comments
Open
1 of 2 tasks

Not possible to follow some links using "f" in certain sites #238

marvinbelfort opened this issue Nov 23, 2017 · 8 comments
Labels
site compatible issue occurs on certain site

Comments

@marvinbelfort
Copy link

marvinbelfort commented Nov 23, 2017

I'm opening this issue because:

  • I'll report a bug
  • I'll propose a new feature

Description

Some links does not show a letter near it when you press "F" or "f", making it impossible to follow.

Steps to Reproduce

In this site: https://golang.org/pkg/os/exec/
Scroll down until you find some "Example" link.
Press "F" or "f"
Every other link can be followed ( shows a letter near it), except the "Example".

System configuration

  • Operating system: Windows 10 and Arch Linux.
  • Firefox version:57.0 64bit.
  • Vim-Vixen version:0.6
@marvinbelfort marvinbelfort changed the title Not possible to follow some links using "f" Not possible to follow some links using "f" in certain sites Nov 23, 2017
@grummi92
Copy link

Probably because those example 'links' aren't links at all, but p elements with added javascript functionality. I'm going out on a limb and say that such 'links' will never be followable by vim-vixen. It just is not possible to recognize such 'links'. Vimperator doesn't support them either.

span

@ueokande
Copy link
Owner

ueokande commented Nov 24, 2017

That is a bad example on web accesibility. Clickable elements must be <button> or <input> elements, or be with attribute role attribute. Vim Vixen can pick such elements.

@AnomalRoil
Copy link

I guess this could be reported as a bug to the Go team.

@grummi92 grummi92 mentioned this issue Dec 3, 2017
2 tasks
@steponeloops
Copy link

Unfortunately this is quite common (looking at you, reddit).
Maybe we could have the possibility to add selectors in the json file - this would be unobtrusive to the "normal" user and still give more experienced users the possibility to solve this problem?

@grummi92
Copy link

grummi92 commented Dec 9, 2017

Just out of curiosity: What exactly does not work on reddit? Had a quick look with vimperator, and I couldn't find any elements not selectable via hints.
If Vim Vixen would support the same selectors for hints as vimperator (see also #257), reddit at least should be no problem.

@steponeloops
Copy link

bildschirmfoto 2017-12-12 um 12 28 44

the expand buttons.

@mathstuf
Copy link
Contributor

In uzbl, we have a "click" action using the same logic as follow, but instead of links, it looks for "clickable" items (including form elements and those with an onclick attribute). Maybe this would be a good addition as a new action?

@Moelf
Copy link

Moelf commented Oct 9, 2018

this even happens for this repo https://github.com/ueokande/vim-vixen

When you first visit the page, press 'f' works, then esc, then C-d about 5 times until you're looking at all text, then you press 'f', nothing shows up, as expected. But now if you esc then 'gg' and 'f' again, links at the top of the pages stop being tagged as well. Very strange behavior.

@ueokande ueokande added the site compatible issue occurs on certain site label Oct 30, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
site compatible issue occurs on certain site
Projects
None yet
Development

No branches or pull requests

7 participants