Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Non-text nodes have some focus/visibility issues. #2113

Open
FrenjaminBanklin opened this issue Sep 27, 2023 · 0 comments
Open

Non-text nodes have some focus/visibility issues. #2113

FrenjaminBanklin opened this issue Sep 27, 2023 · 0 comments
Labels
bug Something isn't working editor front end obo node involving the use of obo nodes

Comments

@FrenjaminBanklin
Copy link
Contributor

FrenjaminBanklin commented Sep 27, 2023

This is happening with YouTube and IFrame nodes, but it's possible this could be a problem for multiple other node types that lack any kind of text component.

The immediately apparent issue:

  • If the first node on a page is a YouTube/IFrame node, that node will steal focus from any text node that is clicked anywhere below it on the page.
    • Example: First node on a page is a YouTube/IFrame node, next node on the page is a Text node. Click the Text node, the YouTube/IFrame node will steal focus.
    • Another example: First node on a page it a YouTube/IFrame node, second node on the page is a Text node, third node is a YouTube/IFrame, fourth node is a Text node. Click on the second node (Text), the first YouTube node steals focus. Click on the fourth node (Text), the first YouTube/IFrame node steals focus. Click the third node (YouTube/IFrame), and you can interact with it properly. Clicking in either of the page's margins will move focus immediately to the first YouTube/IFrame node.

Additionally, in YouTube nodes, once a video is added, the 'Edit' button is not reachable unless the YouTube node loses focus somehow (clicking outside of the node, for example).

It looks like using the up/down arrow keys to navigate page contents skips over YouTube nodes, but the left/right arrow keys can be used to move into YouTube nodes properly. Using the arrow keys to move down from a YouTube node into a Text node seems to be working properly. IFrame nodes seem to be reachable with the up/down arrow keys just fine.

These problems seem to disappear when a text-containing node is present in the page at any point before all YouTube/IFrame nodes.

@FrenjaminBanklin FrenjaminBanklin added bug Something isn't working editor front end obo node involving the use of obo nodes labels Sep 27, 2023
@FrenjaminBanklin FrenjaminBanklin changed the title YouTube node has some focus/visibility issues. Non-text nodes have some focus/visibility issues. Sep 27, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working editor front end obo node involving the use of obo nodes
Projects
None yet
Development

No branches or pull requests

1 participant