Fixed typescript type checking to only scan staged files rather than

entire codebase

- Also fixed other code review comments

Author: rlorenzo

scripts/lint-staged-vue.js

@@ -46,7 +46,7 @@ function sanitizeFilePath(filePath) {
     throw new Error(`File outside VueApp directory: ${filePath}`);
   }
 
-  // Ensure it's a Vue, JS, or TS file
+  // Ensure it's a Vue, JS, TS, JSX, or TSX file
   const allowedExtensions = ['.vue', '.js', '.ts', '.jsx', '.tsx'];
   const ext = path.extname(resolvedPath).toLowerCase();
   if (!allowedExtensions.includes(ext)) {
@@ -109,11 +109,43 @@ try {
   const tsFiles = files.filter(file => /\.(ts|tsx|vue)$/.test(file));
 
   if (tsFiles.length > 0) {
-    // Use vue-tsc for type checking since this is a Vue project
-    const tscArgs = ['--noEmit', ...tsFiles];
+    // Create a temporary tsconfig for only the changed files
+    const tempTsConfig = path.join(vueAppDir, 'tsconfig.lint-staged.json');
+    const baseTsConfig = path.join(vueAppDir, 'tsconfig.app.json');
 
-    if (!runCommand('vue-tsc', tscArgs, 'TypeScript type checking')) {
+    try {
+      // Read the base tsconfig
+      const baseConfig = JSON.parse(fs.readFileSync(baseTsConfig, 'utf8'));
+      
+      // Create a temporary config that includes only the changed files
+      const tempConfig = {
+        ...baseConfig,
+        include: tsFiles.map(file => `./${file}`),
+        exclude: [] // Don't exclude anything for lint-staged
+      };
+      
+      // Write temporary config
+      fs.writeFileSync(tempTsConfig, JSON.stringify(tempConfig, null, 2));
+      
+      // Run vue-tsc with the temporary config
+      const tscArgs = ['--noEmit', '--project', tempTsConfig];
+      
+      if (!runCommand('vue-tsc', tscArgs, 'TypeScript type checking (changed files only)')) {
+        success = false;
+      }
+      
+    } catch (configError) {
+      console.error('Failed to create temporary tsconfig:', configError);
       success = false;
+    } finally {
+      // Clean up temporary config file
+      try {
+        if (fs.existsSync(tempTsConfig)) {
+          fs.unlinkSync(tempTsConfig);
+        }
+      } catch (cleanupError) {
+        console.warn('Failed to clean up temporary tsconfig:', cleanupError);
+      }
     }
   }