Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add availability filter for the issues #189

Open
wants to merge 2 commits into
base: development
Choose a base branch
from

Conversation

koya0
Copy link
Contributor

@koya0 koya0 commented Dec 23, 2024

Resolves #185

QA

qa-filter-availability3.mp4

@ubiquity-os-deployer
Copy link

@koya0 koya0 marked this pull request as ready for review December 23, 2024 20:16
@koya0 koya0 requested a review from 0x4007 as a code owner December 23, 2024 20:16
@zugdev
Copy link
Collaborator

zugdev commented Dec 24, 2024

  1. You need to change in style.css the portrait or max-width to account for the new space. To avoid the following:
Screenshot 2024-12-24 at 18 26 55
  1. You should give a little more padding to the new button, notice the difference:
Screenshot 2024-12-24 at 18 28 13
  1. It's preferable that you allocate the same width for both states of the button instead of changeable width, as the later generally provokes responsiveness issues. Also a general better text could be "Unassigned"/"All Issues", i.e: something shorter.

  2. The mobile view is very broken. I think you could split the space between search bar and it in a 3/1 flex split, if that works. Stacking vertically either makes it very convoluted, confusing and also violates the bottom-bar max height (that could be changed, but I dislike the approach)

Screenshot 2024-12-24 at 18 31 14

I'd create a div that wraps search box and the new button has display: flex, then in search box I'd do flex: 3, and in button/label flex: 1. Be careful of how it impacts the desktop view.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Show Available and In Progress Tasks
2 participants