Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

hot-fix: unpassed arg #1086

Merged
merged 1 commit into from
Feb 25, 2024
Merged

hot-fix: unpassed arg #1086

merged 1 commit into from
Feb 25, 2024

Conversation

Keyrxng
Copy link
Member

@Keyrxng Keyrxng commented Feb 25, 2024

Resolves ubiquity/devpool-directory-tasks#15

mistakenly forgot to pass the arg into checkIfForked()

with my username as DEVPOOL_OWNER_NAME in my test branch new issues are created with www. as we compare DEVPOOL_OWNER_NAME to ubiquity

I cancelled my action run soon as it hit the tweet portion as I haven't set that side up

@0x4007 0x4007 merged commit 4f57c8b into ubiquity:development Feb 25, 2024
2 checks passed
@0x4007
Copy link
Member

0x4007 commented Feb 25, 2024

I still think it's better practice to use IDs instead of names but I guess it's fine for now.

@Keyrxng
Copy link
Member Author

Keyrxng commented Feb 25, 2024

I still think it's better practice to use IDs instead of names but I guess it's fine for now.

I agree IDs would be better but this would force the forkers to have all the permissions set up properly otherwise the check would fail and link spam I think, you obv could catch a failed call and count that as a forked instance but username seems smoother

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Forks should not tag and link back to UBQ issues
2 participants