-
Notifications
You must be signed in to change notification settings - Fork 28
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: no backlinks #1062
feat: no backlinks #1062
Conversation
You need to associate the correct issue. Try:
Also please read: ubiquity/devpool-directory-tasks#15 (comment) |
As far as I understand there are additional requirements for this PR P.S. Test workflow is failing |
Forgot to remove after rebase |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Small details
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Your isFork
logic is backwards
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Are you able to show any proof of testing?
I got it right this time as you were correct it was still backwards |
try { | ||
const { | ||
data: { id }, | ||
} = await octokit.users.getAuthenticated(); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm a little bit concerned that it will authenticate as the bot itself instead of the organization. But I asked ChatGPT and it said that this implementation should be fine.
https://chat.openai.com/share/47cc89cc-cd67-4f68-931f-fe6e1b81ba5e
const { | ||
data: { id }, | ||
} = await octokit.users.getAuthenticated(); | ||
return id !== 76412717; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think the bot ID actually is 113181824
Resolves ubiquity/devpool-directory-tasks#15
Following the fearless leader with this one