Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: no backlinks #1062

Merged
merged 6 commits into from
Feb 18, 2024
Merged

feat: no backlinks #1062

merged 6 commits into from
Feb 18, 2024

Conversation

Keyrxng
Copy link
Member

@Keyrxng Keyrxng commented Feb 15, 2024

Resolves ubiquity/devpool-directory-tasks#15

Following the fearless leader with this one

@Keyrxng
Copy link
Member Author

Keyrxng commented Feb 15, 2024

@pavlovcik

@0x4007
Copy link
Member

0x4007 commented Feb 15, 2024

You need to associate the correct issue. Try:

Resolves https://github.com/ubiquity/devpool-directory-bounties/issues/15

Also please read: ubiquity/devpool-directory-tasks#15 (comment)

@rndquu
Copy link
Member

rndquu commented Feb 16, 2024

As far as I understand there are additional requirements for this PR

P.S. Test workflow is failing

@Keyrxng
Copy link
Member Author

Keyrxng commented Feb 16, 2024

Forgot to remove after rebase

helpers/github.ts Outdated Show resolved Hide resolved
helpers/github.ts Outdated Show resolved Hide resolved
index.ts Outdated Show resolved Hide resolved
Copy link
Member

@0x4007 0x4007 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Small details

Copy link
Member

@0x4007 0x4007 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Your isFork logic is backwards

Copy link
Member

@0x4007 0x4007 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Are you able to show any proof of testing?

@Keyrxng
Copy link
Member Author

Keyrxng commented Feb 17, 2024

Are you able to show any proof of testing?

  • https://github.com/Keyrxng/devpool-directory/issues/7
    which links to https://www.github.com/ubiquity/ubiquity-dollar/issues/833

  • https://github.com/Keyrxng/devpool-directory/issues/5 was the error before the fix
    which links to https://github.com/ubiquity/ubiquity-dollar/issues/833

I got it right this time as you were correct it was still backwards

try {
const {
data: { id },
} = await octokit.users.getAuthenticated();
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm a little bit concerned that it will authenticate as the bot itself instead of the organization. But I asked ChatGPT and it said that this implementation should be fine.

https://chat.openai.com/share/47cc89cc-cd67-4f68-931f-fe6e1b81ba5e

@0x4007 0x4007 merged commit 9f748fb into ubiquity:development Feb 18, 2024
2 checks passed
const {
data: { id },
} = await octokit.users.getAuthenticated();
return id !== 76412717;
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think the bot ID actually is 113181824

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Forks should not tag and link back to UBQ issues
3 participants