Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

manifest.name mismatch #27

Closed
Keyrxng opened this issue Nov 22, 2024 · 1 comment
Closed

manifest.name mismatch #27

Keyrxng opened this issue Nov 22, 2024 · 1 comment

Comments

@Keyrxng
Copy link
Contributor

Keyrxng commented Nov 22, 2024

Manifests need updated so the name matches the intended name which is the name of the repo it lives in.

image

Any mismatch in manifest.name and the plugin repo and we will not be able to install those plugins and the config will look like this:

image

This is because the worker url contains the repo name and we use that to match against manifest.name

relevant context

@rndquu
Copy link
Member

rndquu commented Nov 26, 2024

Can't we treat owner/repository URL as a unique plugin key? Anyway updating the name property is already mentioned in #24.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants