Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Do not break the loop when a plugin fails to run #120

Closed
gentlementlegen opened this issue Sep 30, 2024 · 1 comment · Fixed by #156
Closed

Do not break the loop when a plugin fails to run #120

gentlementlegen opened this issue Sep 30, 2024 · 1 comment · Fixed by #156

Comments

@gentlementlegen
Copy link
Member

          The `command-start-stop` was never called which is why it never worked. The reason is that a plugin is failing on a fatal error because of the new orgs that have been created and somehow doesn't have the proper access level
{
      "message": [
        "Calling handler {\"owner\":\"ubiquibot\",\"repo\":\"user-activity-watcher\",\"workflowId\":\"compute.yml\",\"ref\":\"development\"} for event issue_comment"
      ],
      "level": "log",
      "timestamp": 1727697850120
},
{
      "message": [
        "Error in event handler",
        "HttpError: Resource not accessible by integration - https://docs.github.com/rest/actions/workflows#create-a-workflow-dispatch-event"
      ],
      "level": "error",
      "timestamp": 1727697850679
}

I fixed by making the plugin higher on the list. I believe the loop should not break if a plugin is not working properly but just log the error. Also maintaining 4 repos is complex, these repos won't get moved?

Originally posted by @gentlementlegen in ubiquity/ubiquity-dollar#965 (comment)

If a plugin is not reachable or does not start properly, the loop should continue as plugins are independent.

Copy link

@gentlementlegen the deadline is at Sat, Oct 19, 2:01 AM UTC

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant