Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update the template #34

Closed
whilefoo opened this issue Dec 9, 2024 · 14 comments · Fixed by #38
Closed

Update the template #34

whilefoo opened this issue Dec 9, 2024 · 14 comments · Fixed by #38

Comments

@whilefoo
Copy link
Member

whilefoo commented Dec 9, 2024

This plugin template has become out of date:

  • All plugins now use SDK so this template should also use it
  • Most if not all plugins use bun so this template should also switch to it
  • Out of date dependencies
  • It's still using old workflows, for example update-configuration.yml doesn't use our reusable workflow
  • It doesn't use ncc to build Action plugins
  • Still using CommonJS modules instead of ESM (also for tests)
  • It should use Typescript for eslint, jest and other configs

I'm sure I'm missing some other things but you get the gist, the main task is to update the template so it's more aligned with our current plugin structure

@0x4007
Copy link
Member

0x4007 commented Dec 10, 2024

@whilefoo please confirm the time estimate.

@whilefoo
Copy link
Member Author

I would say 4 hours is fine

@ariesgun
Copy link
Contributor

/start

Copy link
Contributor

! This task does not reflect a business priority at the moment. You may start tasks with one of the following labels: Priority: 3 (High), Priority: 4 (Urgent), Priority: 5 (Emergency)

@henalolp
Copy link

/help

Copy link
Contributor

Available Commands

Command Description Example
/help List all available commands. /help
/allow Allows the user to modify the given label type. /allow @user1 label
/ask Ask any question about the repository, issue or pull request /ask
/query Returns the user's wallet, access, and multiplier information. /query @UbiquityOS
/start Assign yourself and/or others to the issue/task. /start
/stop Unassign yourself from the issue/task. /stop
/wallet Register your wallet address for payments. Use '/wallet unset' to unlink your wallet. /wallet ubq.eth

@henalolp
Copy link

/start

Copy link
Contributor

! This task does not reflect a business priority at the moment. You may start tasks with one of the following labels: Priority: 3 (High), Priority: 4 (Urgent), Priority: 5 (Emergency)

@3scava1i3r
Copy link

@whilefoo what more other than the points noted?

@3scava1i3r
Copy link

/start

@3scava1i3r
Copy link

In the meantime also working on this

Copy link
Contributor

! Please set your wallet address with the /wallet command first and try again.

Copy link
Contributor

Beneficiary 0x0fC1b909ba9265A846b82CF4CE352fc3e7EeB2ED

Tip

  • Use /wallet 0x0000...0000 if you want to update your registered payment wallet address.
  • Be sure to open a draft pull request as soon as possible to communicate updates on your progress.
  • Be sure to provide timely updates to us when requested, or you will be automatically unassigned from the task.

Copy link
Contributor

ubiquity-os-beta bot commented Jan 20, 2025

 [ 200 WXDAI ] 

@gentlementlegen
Contributions Overview
ViewContributionCountReward
IssueTask1200
ReviewComment10
Conversation Incentives
CommentFormattingRelevancePriorityReward
Resolves #34, resolves #37- updated the template to use the SD…
2.5
content:
  content:
    p:
      score: 0
      elementCount: 6
    ul:
      score: 0
      elementCount: 1
    li:
      score: 0.5
      elementCount: 5
  result: 2.5
regex:
  wordCount: 29
  wordValue: 0
  result: 0
0.920

 [ 31.398 WXDAI ] 

@whilefoo
Contributions Overview
ViewContributionCountReward
IssueSpecification128.04
IssueComment10.52
ReviewComment52.838
Conversation Incentives
CommentFormattingRelevancePriorityReward
This plugin template has become out of date:- All plugins now …
14.02
content:
  content:
    p:
      score: 0
      elementCount: 9
    ul:
      score: 0
      elementCount: 1
    li:
      score: 0.5
      elementCount: 7
    a:
      score: 5
      elementCount: 1
  result: 8.5
regex:
  wordCount: 112
  wordValue: 0.1
  result: 5.52
1228.04
I would say 4 hours is fine
0.52
content:
  content:
    p:
      score: 0
      elementCount: 1
  result: 0
regex:
  wordCount: 7
  wordValue: 0.1
  result: 0.52
0.520.52
This also solves #34
0.32
content:
  content:
    p:
      score: 0
      elementCount: 1
  result: 0
regex:
  wordCount: 4
  wordValue: 0.1
  result: 0.32
0.220.128
```suggestionrun: bun ./dist/index.js …
0.59
content:
  content:
    p:
      score: 0
      elementCount: 1
  result: 0
regex:
  wordCount: 8
  wordValue: 0.1
  result: 0.59
0.921.062
I think this is not needed because `action-deploy-plugin`…
0.71
content:
  content:
    p:
      score: 0
      elementCount: 1
  result: 0
regex:
  wordCount: 10
  wordValue: 0.1
  result: 0.71
0.620.852
default value should be at `configurableResponse`
0.39
content:
  content:
    p:
      score: 0
      elementCount: 1
  result: 0
regex:
  wordCount: 5
  wordValue: 0.1
  result: 0.39
0.720.546
you forgot `github.event.workflow_run.head_branch` at &#…
0.25
content:
  content:
    p:
      score: 0
      elementCount: 1
  result: 0
regex:
  wordCount: 3
  wordValue: 0.1
  result: 0.25
0.520.25

 [ 0.43 WXDAI ] 

@3scava1i3r
Contributions Overview
ViewContributionCountReward
IssueComment20.43
Conversation Incentives
CommentFormattingRelevancePriorityReward
@whilefoo what more other than the points noted?
0.59
content:
  content:
    p:
      score: 0
      elementCount: 1
  result: 0
regex:
  wordCount: 8
  wordValue: 0.1
  result: 0.59
120.3
In the meantime also working on this
0.52
content:
  content:
    p:
      score: 0
      elementCount: 1
  result: 0
regex:
  wordCount: 7
  wordValue: 0.1
  result: 0.52
0.520.13

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

6 participants