Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Properly escape content #35

Open
gentlementlegen opened this issue Nov 26, 2024 · 0 comments
Open

Properly escape content #35

gentlementlegen opened this issue Nov 26, 2024 · 0 comments

Comments

@gentlementlegen
Copy link
Member

          <details><summary><b><h3>&nbsp;<a href="https://pay.ubq.fi?claim=W3sidHlwZSI6ImVyYzIwLXBlcm1pdCIsInBlcm1pdCI6eyJwZXJtaXR0ZWQiOnsidG9rZW4iOiIweGU5MUQxNTNFMGI0MTUxOEEyQ2U4RGQzRDc5NDRGYTg2MzQ2M2E5N2QiLCJhbW91bnQiOiI3NjM1MDAwMDAwMDAwMDAwMDAwMCJ9LCJub25jZSI6IjY2MTcyOTE4MTgyMDQ1MjMxOTczMjEwMjg3NzY1Nzk4NzI1MzEyNTI0MjY2OTcyNDU4MzgxNDQ1Njc2NjQxODQxMDE3MDY5MTk3MDM3IiwiZGVhZGxpbmUiOiIxMTU3OTIwODkyMzczMTYxOTU0MjM1NzA5ODUwMDg2ODc5MDc4NTMyNjk5ODQ2NjU2NDA1NjQwMzk0NTc1ODQwMDc5MTMxMjk2Mzk5MzUifSwidHJhbnNmZXJEZXRhaWxzIjp7InRvIjoiMHgwZkMxYjkwOWJhOTI2NUE4NDZiODJDRjRDRTM1MmZjM2U3RWVCMkVEIiwicmVxdWVzdGVkQW1vdW50IjoiNzYzNTAwMDAwMDAwMDAwMDAwMDAifSwib3duZXIiOiIweDkwNTFlRGE5NmRCNDE5Yzk2NzE4OUY0QWMzMDNhMjkwRjMzMjc2ODAiLCJzaWduYXR1cmUiOiIweDViNjI2NmNmYjZhY2ExNjU0NTRiOGRjOGQ2YTgwMmQ5NTA0OWVkMDFjNzg5M2JjZjYzYzNlNjI4MDlkMjU4ZGEwMDVmNmJlNjY5ZmVkZmUwODY3MTFlOWI5MDYwMjE0ZGQ1ZjcxYmFjZGEwN2NkYzNhNTUwMzIwZmIzNzVlZDA2MWMiLCJuZXR3b3JrSWQiOjEwMH1d" target="_blank" rel="noopener">[ 76.35 WXDAI ]</a>&nbsp;</h3><h6>@gentlementlegen</h6></b></summary><h6>Contributions Overview</h6><table><thead><tr><th>View</th><th>Contribution</th><th>Count</th><th>Reward</th></tr></thead><tbody><tr><td>Issue</td><td>Task</td><td>1</td><td>75</td></tr><tr><td>Issue</td><td>Comment</td><td>1</td><td>1.35</td></tr><tr><td>Review</td><td>Comment</td><td>8</td><td>0</td></tr></tbody></table><h6>Conversation Incentives</h6><table><thead><tr><th>Comment</th><th>Formatting</th><th>Relevance</th><th>Priority</th><th>Reward</th></tr></thead><tbody><tr><td><h6><a href="https://github.com/ubiquity-os-marketplace/text-conversation-rewards/issues/155#issuecomment-2481395569" target="_blank" rel="noopener">@0x4007 Seeing the spec being modified by the bot, it actually a&hellip;</a></h6></td><td><details><summary>1.8</summary><pre>content:&#13;  content:&#13;    p:&#13;      score: 0&#13;      elementCount: 1&#13;  result: 0&#13;regex:&#13;  wordCount: 30&#13;  wordValue: 0.1&#13;  result: 1.8&#13;</pre></details></td><td>1</td><td>3</td><td>1.35</td></tr><tr><td><h6><a href="https://github.com/ubiquity-os-marketplace/text-conversation-rewards/pull/188" target="_blank" rel="noopener">Resolves #155 Depends on https://github.com/ubiquity-os-market&hellip;</a></h6></td><td><details><summary>15</summary><pre>content:&#13;  content:&#13;    p:&#13;      score: 0&#13;      elementCount: 5&#13;    a:&#13;      score: 5&#13;      elementCount: 3&#13;  result: 15&#13;regex:&#13;  wordCount: 11&#13;  wordValue: 0&#13;  result: 0&#13;</pre></details></td><td>0.2</td><td>3</td><td>0</td></tr><tr><td><h6><a href="https://github.com/ubiquity-os-marketplace/text-conversation-rewards/pull/188#discussion_r1855896130" target="_blank" rel="noopener">The problem with that is the bot comments multiple times and you&hellip;</a></h6></td><td><details><summary>5</summary><pre>content:&#13;  content:&#13;    p:&#13;      score: 0&#13;      elementCount: 4&#13;    a:&#13;      score: 5&#13;      elementCount: 1&#13;  result: 5&#13;regex:&#13;  wordCount: 75&#13;  wordValue: 0&#13;  result: 0&#13;</pre></details></td><td>0.6</td><td>3</td><td>0</td></tr><tr><td><h6><a href="https://github.com/ubiquity-os-marketplace/text-conversation-rewards/pull/188#discussion_r1855988658" target="_blank" rel="noopener">I checked other comments and some are mixed, some are not. Maybe&hellip;</a></h6></td><td><details><summary>5</summary><pre>content:&#13;  content:&#13;    p:&#13;      score: 0&#13;      elementCount: 1&#13;    a:&#13;      score: 5&#13;      elementCount: 1&#13;  result: 5&#13;regex:&#13;  wordCount: 56&#13;  wordValue: 0&#13;  result: 0&#13;</pre></details></td><td>0.7</td><td>3</td><td>0</td></tr><tr><td><h6><a href="https://github.com/ubiquity-os-marketplace/text-conversation-rewards/pull/188#discussion_r1856110897" target="_blank" rel="noopener">Reliably depends mostly on GitHub API I suppose, sometimes I mus&hellip;</a></h6></td><td><details><summary>0</summary><pre>content:&#13;  content:&#13;    p:&#13;      score: 0&#13;      elementCount: 1&#13;  result: 0&#13;regex:&#13;  wordCount: 36&#13;  wordValue: 0&#13;  result: 0&#13;</pre></details></td><td>0.5</td><td>3</td><td>0</td></tr><tr><td><h6><a href="https://github.com/ubiquity-os-marketplace/text-conversation-rewards/pull/188#discussion_r1857154848" target="_blank" rel="noopener">Then it makes more sense to keep it generic for now and remove t&hellip;</a></h6></td><td><details><summary>0</summary><pre>content:&#13;  content:&#13;    p:&#13;      score: 0&#13;      elementCount: 1&#13;  result: 0&#13;regex:&#13;  wordCount: 28&#13;  wordValue: 0&#13;  result: 0&#13;</pre></details></td><td>0.9</td><td>3</td><td>0</td></tr><tr><td><h6><a href="https://github.com/ubiquity-os-marketplace/text-conversation-rewards/pull/188#issuecomment-2490080332" target="_blank" rel="noopener">@whilefoo If you can have a look</a></h6></td><td><details><summary>0</summary><pre>content:&#13;  content:&#13;    p:&#13;      score: 0&#13;      elementCount: 1&#13;  result: 0&#13;regex:&#13;  wordCount: 7&#13;  wordValue: 0&#13;  result: 0&#13;</pre></details></td><td>0.1</td><td>3</td><td>0</td></tr><tr><td><h6><a href="https://github.com/ubiquity-os-marketplace/text-conversation-rewards/pull/188#issuecomment-2495474757" target="_blank" rel="noopener">@0x4007 👀</a></h6></td><td><details><summary>0</summary><pre>content:&#13;  content:&#13;    p:&#13;      score: 0&#13;      elementCount: 1&#13;  result: 0&#13;regex:&#13;  wordCount: 1&#13;  wordValue: 0&#13;  result: 0&#13;</pre></details></td><td>0.1</td><td>3</td><td>0</td></tr><tr><td><h6><a href="https://github.com/ubiquity-os-marketplace/text-conversation-rewards/pull/188#issuecomment-2499975261" target="_blank" rel="noopener">I will do it separately because that includes multiple different&hellip;</a></h6></td><td><details><summary>0</summary><pre>content:&#13;  content:&#13;    p:&#13;      score: 0&#13;      elementCount: 1&#13;  result: 0&#13;regex:&#13;  wordCount: 36&#13;  wordValue: 0&#13;  result: 0&#13;</pre></details></td><td>0.8</td><td>3</td><td>0</td></tr></tbody></table></details><details><summary><b><h3>&nbsp;<a href="https://pay.ubq.fi?claim=W3sidHlwZSI6ImVyYzIwLXBlcm1pdCIsInBlcm1pdCI6eyJwZXJtaXR0ZWQiOnsidG9rZW4iOiIweGU5MUQxNTNFMGI0MTUxOEEyQ2U4RGQzRDc5NDRGYTg2MzQ2M2E5N2QiLCJhbW91bnQiOiIxMTA4NzQwMDAwMDAwMDAwMDAwMDAifSwibm9uY2UiOiI2MDA3MzE0Mjc3Njg5MzE5OTkyMTI1ODE2NjcwNjc1NTczMDA4Mzg3NTI4Nzk1NDM2MDIwNDYwNjQ2MzY0ODAzMTQ5OTA5ODM4OTU0MiIsImRlYWRsaW5lIjoiMTE1NzkyMDg5MjM3MzE2MTk1NDIzNTcwOTg1MDA4Njg3OTA3ODUzMjY5OTg0NjY1NjQwNTY0MDM5NDU3NTg0MDA3OTEzMTI5NjM5OTM1In0sInRyYW5zZmVyRGV0YWlscyI6eyJ0byI6IjB4NDAwN0NFMjA4M2M3RjNFMTgwOTdhZUIzQTM5YmI4ZUMxNDlhMzQxZCIsInJlcXVlc3RlZEFtb3VudCI6IjExMDg3NDAwMDAwMDAwMDAwMDAwMCJ9LCJvd25lciI6IjB4OTA1MWVEYTk2ZEI0MTljOTY3MTg5RjRBYzMwM2EyOTBGMzMyNzY4MCIsInNpZ25hdHVyZSI6IjB4MDAzZThmZWUzYmQyMWE2NDM4NDFkN2UyOWRjNzBlNWYwNDUzOTc3ZTg3YzNkMzgyOGYyNzk2ZDk0MDhmNWQ0NjM2ZTIzODQ0MmRkODc2ZmY1ZWU3MDUzMGZkNTQ5OGNjMWY1NzBkZTM3NGMwMDcyZTZmMDhkYzg3MDU0OGViYjUxYyIsIm5ldHdvcmtJZCI6MTAwfV0=" target="_blank" rel="noopener">[ 110.874 WXDAI ]</a>&nbsp;</h3><h6>@0x4007</h6></b></summary><h6>Contributions Overview</h6><table><thead><tr><th>View</th><th>Contribution</th><th>Count</th><th>Reward</th></tr></thead><tbody><tr><td>Issue</td><td>Specification</td><td>1</td><td>88.11</td></tr><tr><td>Issue</td><td>Comment</td><td>1</td><td>3.99</td></tr><tr><td>Review</td><td>Comment</td><td>8</td><td>18.774</td></tr></tbody></table><h6>Conversation Incentives</h6><table><thead><tr><th>Comment</th><th>Formatting</th><th>Relevance</th><th>Priority</th><th>Reward</th></tr></thead><tbody><tr><td><h6><a href="https://github.com/ubiquity-os-marketplace/text-conversation-rewards/issues/155" target="_blank" rel="noopener">- When aggregating rewards, collect every link into a single dat&hellip;</a></h6></td><td><details><summary>9.79</summary><pre>content:&#13;  content:&#13;    ul:&#13;      score: 0&#13;      elementCount: 1&#13;    li:&#13;      score: 0.5&#13;      elementCount: 3&#13;    p:&#13;      score: 0&#13;      elementCount: 3&#13;    a:&#13;      score: 5&#13;      elementCount: 1&#13;  result: 6.5&#13;regex:&#13;  wordCount: 61&#13;  wordValue: 0.1&#13;  result: 3.29&#13;</pre></details></td><td>1</td><td>3</td><td>88.11</td></tr><tr><td><h6><a href="https://github.com/ubiquity-os-marketplace/text-conversation-rewards/issues/155#issuecomment-2482259516" target="_blank" rel="noopener">Yeah thats tough. I suppose the direct solution would be a confi&hellip;</a></h6></td><td><details><summary>1.33</summary><pre>content:&#13;  content:&#13;    p:&#13;      score: 0&#13;      elementCount: 1&#13;  result: 0&#13;regex:&#13;  wordCount: 21&#13;  wordValue: 0.1&#13;  result: 1.33&#13;</pre></details></td><td>1</td><td>3</td><td>3.99</td></tr><tr><td><h6><a href="https://github.com/ubiquity-os-marketplace/text-conversation-rewards/pull/188#discussion_r1846078456" target="_blank" rel="noopener">&#96;&#96;&#96;suggestionthrow this.context.logger.error&hellip;</a></h6></td><td><details><summary>0</summary><pre>content:&#13;  content: {}&#13;  result: 0&#13;regex:&#13;  wordCount: 0&#13;  wordValue: 0.1&#13;  result: 0&#13;</pre></details></td><td>0.7</td><td>3</td><td>0</td></tr><tr><td><h6><a href="https://github.com/ubiquity-os-marketplace/text-conversation-rewards/pull/188#discussion_r1846078834" target="_blank" rel="noopener">We are intending to link an emergency triage telegram channel to&hellip;</a></h6></td><td><details><summary>1.59</summary><pre>content:&#13;  content:&#13;    p:&#13;      score: 0&#13;      elementCount: 1&#13;  result: 0&#13;regex:&#13;  wordCount: 26&#13;  wordValue: 0.1&#13;  result: 1.59&#13;</pre></details></td><td>0.6</td><td>3</td><td>2.862</td></tr><tr><td><h6><a href="https://github.com/ubiquity-os-marketplace/text-conversation-rewards/pull/188#discussion_r1846080261" target="_blank" rel="noopener">What is elaborate in this context</a></h6></td><td><details><summary>0.46</summary><pre>content:&#13;  content:&#13;    p:&#13;      score: 0&#13;      elementCount: 1&#13;  result: 0&#13;regex:&#13;  wordCount: 6&#13;  wordValue: 0.1&#13;  result: 0.46&#13;</pre></details></td><td>0.4</td><td>3</td><td>0.552</td></tr><tr><td><h6><a href="https://github.com/ubiquity-os-marketplace/text-conversation-rewards/pull/188#discussion_r1855852452" target="_blank" rel="noopener">This approach seems wrong. You should check revision history and&hellip;</a></h6></td><td><details><summary>1.22</summary><pre>content:&#13;  content:&#13;    p:&#13;      score: 0&#13;      elementCount: 1&#13;  result: 0&#13;regex:&#13;  wordCount: 19&#13;  wordValue: 0.1&#13;  result: 1.22&#13;</pre></details></td><td>0.8</td><td>3</td><td>2.928</td></tr><tr><td><h6><a href="https://github.com/ubiquity-os-marketplace/text-conversation-rewards/pull/188#discussion_r1855853419" target="_blank" rel="noopener">I'm assuming this is for unique anchors. You should consider the&hellip;</a></h6></td><td><details><summary>1.8</summary><pre>content:&#13;  content:&#13;    p:&#13;      score: 0&#13;      elementCount: 1&#13;  result: 0&#13;regex:&#13;  wordCount: 30&#13;  wordValue: 0.1&#13;  result: 1.8&#13;</pre></details></td><td>0.9</td><td>3</td><td>4.86</td></tr><tr><td><h6><a href="https://github.com/ubiquity-os-marketplace/text-conversation-rewards/pull/188#discussion_r1855922266" target="_blank" rel="noopener">@sshivaditya any ideas on how to improve the bot edit implementa&hellip;</a></h6></td><td><details><summary>2.87</summary><pre>content:&#13;  content:&#13;    p:&#13;      score: 0&#13;      elementCount: 1&#13;  result: 0&#13;regex:&#13;  wordCount: 52&#13;  wordValue: 0.1&#13;  result: 2.87&#13;</pre></details></td><td>0.5</td><td>3</td><td>4.305</td></tr><tr><td><h6><a href="https://github.com/ubiquity-os-marketplace/text-conversation-rewards/pull/188#discussion_r1856073266" target="_blank" rel="noopener">I would try implementing the diff approach and if it is too diff&hellip;</a></h6></td><td><details><summary>1.65</summary><pre>content:&#13;  content:&#13;    p:&#13;      score: 0&#13;      elementCount: 1&#13;  result: 0&#13;regex:&#13;  wordCount: 27&#13;  wordValue: 0.1&#13;  result: 1.65&#13;</pre></details></td><td>0.5</td><td>3</td><td>2.475</td></tr><tr><td><h6><a href="https://github.com/ubiquity-os-marketplace/text-conversation-rewards/pull/188#issuecomment-2499968947" target="_blank" rel="noopener">Handle diffs in separate task if you can't do it quickly here.</a></h6></td><td><details><summary>0.88</summary><pre>content:&#13;  content:&#13;    p:&#13;      score: 0&#13;      elementCount: 1&#13;  result: 0&#13;regex:&#13;  wordCount: 13&#13;  wordValue: 0.1&#13;  result: 0.88&#13;</pre></details></td><td>0.3</td><td>3</td><td>0.792</td></tr></tbody></table></details><details><summary><b><h3>&nbsp;<a href="https://pay.ubq.fi?claim=W3sidHlwZSI6ImVyYzIwLXBlcm1pdCIsInBlcm1pdCI6eyJwZXJtaXR0ZWQiOnsidG9rZW4iOiIweGU5MUQxNTNFMGI0MTUxOEEyQ2U4RGQzRDc5NDRGYTg2MzQ2M2E5N2QiLCJhbW91bnQiOiIzMDAwMDAwMDAwMDAwMDAwMDAifSwibm9uY2UiOiI4OTMwOTAzNTcyNDQ0Mzc0NjE4MTI2MDc1MDExMjI1MzM0MzgzNTQwNzAyMjU5MTQ4MzEwODc3MzExMzEwOTE4OTA4MjkxMDg5Mzg3MSIsImRlYWRsaW5lIjoiMTE1NzkyMDg5MjM3MzE2MTk1NDIzNTcwOTg1MDA4Njg3OTA3ODUzMjY5OTg0NjY1NjQwNTY0MDM5NDU3NTg0MDA3OTEzMTI5NjM5OTM1In0sInRyYW5zZmVyRGV0YWlscyI6eyJ0byI6IjB4QWU1RDFGMTkyMDEzZGI4ODliMWUyMTE1QTM3MGFCMTMzZjM1OTc2NSIsInJlcXVlc3RlZEFtb3VudCI6IjMwMDAwMDAwMDAwMDAwMDAwMCJ9LCJvd25lciI6IjB4OTA1MWVEYTk2ZEI0MTljOTY3MTg5RjRBYzMwM2EyOTBGMzMyNzY4MCIsInNpZ25hdHVyZSI6IjB4MTlkYjI2MmEyZDQ0MDUyNmUwYzZjNmJkMjQxMDYzYTllMDRjM2JhZTAxYWMxNjNlY2Y5ZTRmYjk0ZTU1NDBkYzQ2N2M4Njk3ODAyOGZkNGE0YzMzYjk4Y2JlYWVlMjlhNWZmYmI0NDMxYjljMzAxOWEwNmYwOWUxZGIyMTVmN2ExYiIsIm5ldHdvcmtJZCI6MTAwfV0=" target="_blank" rel="noopener">[ 0.3 WXDAI ]</a>&nbsp;</h3><h6>@Keyrxng</h6></b></summary><h6>Contributions Overview</h6><table><thead><tr><th>View</th><th>Contribution</th><th>Count</th><th>Reward</th></tr></thead><tbody><tr><td>Review</td><td>Comment</td><td>1</td><td>0.3</td></tr></tbody></table><h6>Conversation Incentives</h6><table><thead><tr><th>Comment</th><th>Formatting</th><th>Relevance</th><th>Priority</th><th>Reward</th></tr></thead><tbody><tr><td><h6><a href="https://github.com/ubiquity-os-marketplace/text-conversation-rewards/pull/188#issuecomment-2495477579" target="_blank" rel="noopener">I'm happy to get back to performing reviews - I just need the gr&hellip;</a></h6></td><td><details><summary>1</summary><pre>content:&#13;  content:&#13;    p:&#13;      score: 0&#13;      elementCount: 1&#13;  result: 0&#13;regex:&#13;  wordCount: 15&#13;  wordValue: 0.1&#13;  result: 1&#13;</pre></details></td><td>0.1</td><td>3</td><td>0.3</td></tr></tbody></table></details>
/g, \"\")\n+ // Remove the footnotes\n+ .replace(/^###### .*?\\[\\^\\d+\\^][\\s\\S]*$/gm, \"\")",
      "score": {
        "reward": 0,
        "formatting": {
          "content": {
            "p": {
              "score": 0,
              "elementCount": 4
            },
            "a": {
              "score": 5,
              "elementCount": 1
            }
          },
          "result": 5
        },
        "priority": 3,
        "words": {
          "wordCount": 75,
          "wordValue": 0,
          "result": 0
        },
        "multiplier": 0,
        "relevance": 0.6
      }
    },
    {
      "id": 1855988658,
      "content": "I checked other comments and some are mixed, some are not. Maybe you changed a tab by accident when editing or something. In https://github.com/ubiquity-os-marketplace/text-conversation-rewards/issues/143 for example it is ok. So either we keep the regex to cleanup because it is more accurate, either we use the diffs with the risk of rewarding links that should not be?",
      "url": "https://github.com/ubiquity-os-marketplace/text-conversation-rewards/pull/188#discussion_r1855988658",
      "type": "PULL_AUTHOR",
      "diffHunk": "@@ -33,6 +33,8 @@ export class DataPurgeModule extends BaseModule {\n           .replace(/^\\/.+/g, \"\")\n           // Remove HTML comments\n           .replace(/<!--[\\s\\S]*?-->/g, \"\")\n+          // Remove the footnotes\n+          .replace(/^###### .*?\\[\\^\\d+\\^][\\s\\S]*$/gm, \"\")",
      "score": {
        "reward": 0,
        "formatting": {
          "content": {
            "p": {
              "score": 0,
              "elementCount": 1
            },
            "a": {
              "score": 5,
              "elementCount": 1
            }
          },
          "result": 5
        },
        "priority": 3,
        "words": {
          "wordCount": 56,
          "wordValue": 0,
          "result": 0
        },
        "multiplier": 0,
        "relevance": 0.7
      }
    },
    {
      "id": 1856110897,
      "content": "Reliably depends mostly on GitHub API I suppose, sometimes I must say it looks weird because the \"diff\" is just the comment you posted not a diff formatted content. Making a separate spec to explore this.",
      "url": "https://github.com/ubiquity-os-marketplace/text-conversation-rewards/pull/188#discussion_r1856110897",
      "type": "PULL_AUTHOR",
      "diffHunk": "@@ -33,6 +33,8 @@ export class DataPurgeModule extends BaseModule {\n           .replace(/^\\/.+/g, \"\")\n           // Remove HTML comments\n           .replace(/<!--[\\s\\S]*?-->/g, \"\")\n+          // Remove the footnotes\n+          .replace(/^###### .*?\\[\\^\\d+\\^][\\s\\S]*$/gm, \"\")",
      "score": {
        "reward": 0,
        "formatting": {
          "content": {
            "p": {
              "score": 0,
              "elementCount": 1
            }
          },
          "result": 0
        },
        "priority": 3,
        "words": {
          "wordCount": 36,
          "wordValue": 0,
          "result": 0
        },
        "multiplier": 0,
        "relevance": 0.5
      }
    },
    {
      "id": 1857154848,
      "content": "Then it makes more sense to keep it generic for now and remove the footnotes entirely. I will try to implement an effective diff in a separate PR.",
      "url": "https://github.com/ubiquity-os-marketplace/text-conversation-rewards/pull/188#discussion_r1857154848",
      "type": "PULL_AUTHOR",
      "diffHunk": "@@ -33,6 +33,8 @@ export class DataPurgeModule extends BaseModule {\n           .replace(/^\\/.+/g, \"\")\n           // Remove HTML comments\n           .replace(/<!--[\\s\\S]*?-->/g, \"\")\n+          // Remove the footnotes\n+          .replace(/^###### .*?\\[\\^\\d+\\^][\\s\\S]*$/gm, \"\")",
      "score": {
        "reward": 0,
        "formatting": {
          "content": {
            "p": {
              "score": 0,
              "elementCount": 1
            }
          },
          "result": 0
        },
        "priority": 3,
        "words": {
          "wordCount": 28,
          "wordValue": 0,
          "result": 0
        },
        "multiplier": 0,
        "relevance": 0.9
      }
    },
    {
      "id": 2490080332,
      "content": "@whilefoo If you can have a look",
      "url": "https://github.com/ubiquity-os-marketplace/text-conversation-rewards/pull/188#issuecomment-2490080332",
      "type": "PULL_AUTHOR",
      "score": {
        "reward": 0,
        "formatting": {
          "content": {
            "p": {
              "score": 0,
              "elementCount": 1
            }
          },
          "result": 0
        },
        "priority": 3,
        "words": {
          "wordCount": 7,
          "wordValue": 0,
          "result": 0
        },
        "multiplier": 0,
        "relevance": 0.1
      }
    },
    {
      "id": 2495474757,
      "content": "@0x4007 👀",
      "url": "https://github.com/ubiquity-os-marketplace/text-conversation-rewards/pull/188#issuecomment-2495474757",
      "type": "PULL_AUTHOR",
      "score": {
        "reward": 0,
        "formatting": {
          "content": {
            "p": {
              "score": 0,
              "elementCount": 1
            }
          },
          "result": 0
        },
        "priority": 3,
        "words": {
          "wordCount": 1,
          "wordValue": 0,
          "result": 0
        },
        "multiplier": 0,
        "relevance": 0.1
      }
    },
    {
      "id": 2499975261,
      "content": "I will do it separately because that includes multiple different API calls and add quite some complexity if we need to treat all the comments history, and lots of testing. I'll take care of it.",
      "url": "https://github.com/ubiquity-os-marketplace/text-conversation-rewards/pull/188#issuecomment-2499975261",
      "type": "PULL_AUTHOR",
      "score": {
        "reward": 0,
        "formatting": {
          "content": {
            "p": {
              "score": 0,
              "elementCount": 1
            }
          },
          "result": 0
        },
        "priority": 3,
        "words": {
          "wordCount": 36,
          "wordValue": 0,
          "result": 0
        },
        "multiplier": 0,
        "relevance": 0.8
      }
    }
  ],
  "permitUrl": "https://pay.ubq.fi?claim=W3sidHlwZSI6ImVyYzIwLXBlcm1pdCIsInBlcm1pdCI6eyJwZXJtaXR0ZWQiOnsidG9rZW4iOiIweGU5MUQxNTNFMGI0MTUxOEEyQ2U4RGQzRDc5NDRGYTg2MzQ2M2E5N2QiLCJhbW91bnQiOiI3NjM1MDAwMDAwMDAwMDAwMDAwMCJ9LCJub25jZSI6IjY2MTcyOTE4MTgyMDQ1MjMxOTczMjEwMjg3NzY1Nzk4NzI1MzEyNTI0MjY2OTcyNDU4MzgxNDQ1Njc2NjQxODQxMDE3MDY5MTk3MDM3IiwiZGVhZGxpbmUiOiIxMTU3OTIwODkyMzczMTYxOTU0MjM1NzA5ODUwMDg2ODc5MDc4NTMyNjk5ODQ2NjU2NDA1NjQwMzk0NTc1ODQwMDc5MTMxMjk2Mzk5MzUifSwidHJhbnNmZXJEZXRhaWxzIjp7InRvIjoiMHgwZkMxYjkwOWJhOTI2NUE4NDZiODJDRjRDRTM1MmZjM2U3RWVCMkVEIiwicmVxdWVzdGVkQW1vdW50IjoiNzYzNTAwMDAwMDAwMDAwMDAwMDAifSwib3duZXIiOiIweDkwNTFlRGE5NmRCNDE5Yzk2NzE4OUY0QWMzMDNhMjkwRjMzMjc2ODAiLCJzaWduYXR1cmUiOiIweDViNjI2NmNmYjZhY2ExNjU0NTRiOGRjOGQ2YTgwMmQ5NTA0OWVkMDFjNzg5M2JjZjYzYzNlNjI4MDlkMjU4ZGEwMDVmNmJlNjY5ZmVkZmUwODY3MTFlOWI5MDYwMjE0ZGQ1ZjcxYmFjZGEwN2NkYzNhNTUwMzIwZmIzNzVlZDA2MWMiLCJuZXR3b3JrSWQiOjEwMH1d"
},
"0x4007": {
  "total": 110.874,
  "userId": 4975670,
  "comments": [
    {
      "id": 2482259516,
      "content": "Yeah thats tough. I suppose the direct solution would be a config to disable footnote link credits (find lines prefixed with `\\[\\^.*\\]:`)",
      "url": "https://github.com/ubiquity-os-marketplace/text-conversation-rewards/issues/155#issuecomment-2482259516",
      "type": "ISSUE_AUTHOR",
      "score": {
        "reward": 3.99,
        "formatting": {
          "content": {
            "p": {
              "score": 0,
              "elementCount": 1
            }
          },
          "result": 0
        },
        "priority": 3,
        "words": {
          "wordCount": 21,
          "wordValue": 0.1,
          "result": 1.33
        },
        "multiplier": 1,
        "relevance": 1
      }
    },
    {
      "id": 2579216666,
      "content": "- When aggregating rewards, collect every link into a single data store and only credit the first instance of a link. \r\n- In the following issue specification, I got way too much in rewards which can be solved by checking the redundant link (the only difference is the hash, which shouldn't count) I should have only received credit for basically one link. \r\n- https://github.com/ubiquity-os-marketplace/text-conversation-rewards/issues/143",
      "url": "https://github.com/ubiquity-os-marketplace/text-conversation-rewards/issues/155",
      "type": "ISSUE_SPECIFICATION",
      "score": {
        "reward": 88.11,
        "formatting": {
          "content": {
            "ul": {
              "score": 0,
              "elementCount": 1
            },
            "li": {
              "score": 0.5,
              "elementCount": 3
            },
            "p": {
              "score": 0,
              "elementCount": 3
            },
            "a": {
              "score": 5,
              "elementCount": 1
            }
          },
          "result": 6.5
        },
        "priority": 3,
        "words": {
          "wordCount": 61,
          "wordValue": 0.1,
          "result": 3.29
        },
        "multiplier": 3,
        "relevance": 1
      }
    },
    {
      "id": 1846078456,
      "content": "```suggestion\r\n      throw this.context.logger.error(\"Relevance / Comment length mismatch!\", {\r\n```",
      "url": "https://github.com/ubiquity-os-marketplace/text-conversation-rewards/pull/188#discussion_r1846078456",
      "type": "PULL_COLLABORATOR",
      "diffHunk": "@@ -109,7 +109,11 @@ export class ContentEvaluatorModule extends BaseModule {\n     );\n \n     if (Object.keys(relevancesByAi).length !== commentsToEvaluate.length + prCommentsToEvaluate.length) {\n-      throw this.context.logger.fatal(\"Relevance / Comment length mismatch!\", { relevancesByAi, commentsToEvaluate });\n+      throw this.context.logger.fatal(\"Relevance / Comment length mismatch!\", {",
      "score": {
        "reward": 0,
        "formatting": {
          "content": {},
          "result": 0
        },
        "priority": 3,
        "words": {
          "wordCount": 0,
          "wordValue": 0.1,
          "result": 0
        },
        "multiplier": 1,
        "relevance": 0.7
      }
    },
    {
      "id": 1846078834,
      "content": "We are intending to link an emergency triage telegram channel to fatal errors so it should only be 1. consistent errors and 2. probably kernel related",
      "url": "https://github.com/ubiquity-os-marketplace/text-conversation-rewards/pull/188#discussion_r1846078834",
      "type": "PULL_COLLABORATOR",
      "diffHunk": "@@ -109,7 +109,11 @@ export class ContentEvaluatorModule extends BaseModule {\n     );\n \n     if (Object.keys(relevancesByAi).length !== commentsToEvaluate.length + prCommentsToEvaluate.length) {\n-      throw this.context.logger.fatal(\"Relevance / Comment length mismatch!\", { relevancesByAi, commentsToEvaluate });\n+      throw this.context.logger.fatal(\"Relevance / Comment length mismatch!\", {",
      "score": {
        "reward": 2.862,
        "formatting": {
          "content": {
            "p": {
              "score": 0,
              "elementCount": 1
            }
          },
          "result": 0
        },
        "priority": 3,
        "words": {
          "wordCount": 26,
          "wordValue": 0.1,
          "result": 1.59
        },
        "multiplier": 1,
        "relevance": 0.6
      }
    },
    {
      "id": 1846080261,
      "content": "What is elaborate in this context",
      "url": "https://github.com/ubiquity-os-marketplace/text-conversation-rewards/pull/188#discussion_r1846080261",
      "type": "PULL_COLLABORATOR",
      "diffHunk": "@@ -0,0 +1,12 @@\n+# This file serves as a base to elaborate a custom configuration",
      "score": {
        "reward": 0.552,
        "formatting": {
          "content": {
            "p": {
              "score": 0,
              "elementCount": 1
            }
          },
          "result": 0
        },
        "priority": 3,
        "words": {
          "wordCount": 6,
          "wordValue": 0.1,
          "result": 0.46
        },
        "multiplier": 1,
        "relevance": 0.4
      }
    },
    {
      "id": 1855852452,
      "content": "This approach seems wrong. You should check revision history and remove any content added by bots or other users.",
      "url": "https://github.com/ubiquity-os-marketplace/text-conversation-rewards/pull/188#discussion_r1855852452",
      "type": "PULL_COLLABORATOR",
      "diffHunk": "@@ -33,6 +33,8 @@ export class DataPurgeModule extends BaseModule {\n           .replace(/^\\/.+/g, \"\")\n           // Remove HTML comments\n           .replace(/<!--[\\s\\S]*?-->/g, \"\")\n+          // Remove the footnotes\n+          .replace(/^###### .*?\\[\\^\\d+\\^][\\s\\S]*$/gm, \"\")",
      "score": {
        "reward": 2.928,
        "formatting": {
          "content": {
            "p": {
              "score": 0,
              "elementCount": 1
            }
          },
          "result": 0
        },
        "priority": 3,
        "words": {
          "wordCount": 19,
          "wordValue": 0.1,
          "result": 1.22
        },
        "multiplier": 1,
        "relevance": 0.8
      }
    },
    {
      "id": 1855853419,
      "content": "I'm assuming this is for unique anchors. You should consider the query parameter as well. I think let's just consider them the same link with different query parameters.",
      "url": "https://github.com/ubiquity-os-marketplace/text-conversation-rewards/pull/188#discussion_r1855853419",
      "type": "PULL_COLLABORATOR",
      "diffHunk": "@@ -168,9 +170,26 @@ export class FormattingEvaluatorModule extends BaseModule {\n         element.remove();\n         continue;\n       }\n-      this._updateTagCount(formatting, tagName, score);\n+      if (tagName === \"a\") {\n+        const url = element.getAttribute(\"href\");\n+        if (url) {\n+          urlSet.add(url.split(\"#\")[0]);",
      "score": {
        "reward": 4.86,
        "formatting": {
          "content": {
            "p": {
              "score": 0,
              "elementCount": 1
            }
          },
          "result": 0
        },
        "priority": 3,
        "words": {
          "wordCount": 30,
          "wordValue": 0.1,
          "result": 1.8
        },
        "multiplier": 1,
        "relevance": 0.9
      }
    },
    {
      "id": 1855922266,
      "content": "@sshivaditya any ideas on how to improve the bot edit implementation? To me it seems obvious to compare before and after and not make an edit if the results are the same. \nOtherwise we might be able to annotate the inserted links in a specific way to at least handle this situation",
      "url": "https://github.com/ubiquity-os-marketplace/text-conversation-rewards/pull/188#discussion_r1855922266",
      "type": "PULL_COLLABORATOR",
      "diffHunk": "@@ -33,6 +33,8 @@ export class DataPurgeModule extends BaseModule {\n           .replace(/^\\/.+/g, \"\")\n           // Remove HTML comments\n           .replace(/<!--[\\s\\S]*?-->/g, \"\")\n+          // Remove the footnotes\n+          .replace(/^###### .*?\\[\\^\\d+\\^][\\s\\S]*$/gm, \"\")",
      "score": {
        "reward": 4.305,
        "formatting": {
          "content": {
            "p": {
              "score": 0,
              "elementCount": 1
            }
          },
          "result": 0
        },
        "priority": 3,
        "words": {
          "wordCount": 52,
          "wordValue": 0.1,
          "result": 2.87
        },
        "multiplier": 1,
        "relevance": 0.5
      }
    },
    {
      "id": 1856073266,
      "content": "I would try implementing the diff approach and if it is too difficult to get it to work reliably then I would go with your current implementation.",
      "url": "https://github.com/ubiquity-os-marketplace/text-conversation-rewards/pull/188#discussion_r1856073266",
      "type": "PULL_COLLABORATOR",
      "diffHunk": "@@ -33,6 +33,8 @@ export class DataPurgeModule extends BaseModule {\n           .replace(/^\\/.+/g, \"\")\n           // Remove HTML comments\n           .replace(/<!--[\\s\\S]*?-->/g, \"\")\n+          // Remove the footnotes\n+          .replace(/^###### .*?\\[\\^\\d+\\^][\\s\\S]*$/gm, \"\")",
      "score": {
        "reward": 2.475,
        "formatting": {
          "content": {
            "p": {
              "score": 0,
              "elementCount": 1
            }
          },
          "result": 0
        },
        "priority": 3,
        "words": {
          "wordCount": 27,
          "wordValue": 0.1,
          "result": 1.65
        },
        "multiplier": 1,
        "relevance": 0.5
      }
    },
    {
      "id": 2499968947,
      "content": "Handle diffs in separate task if you can't do it quickly here.",
      "url": "https://github.com/ubiquity-os-marketplace/text-conversation-rewards/pull/188#issuecomment-2499968947",
      "type": "PULL_COLLABORATOR",
      "score": {
        "reward": 0.792,
        "formatting": {
          "content": {
            "p": {
              "score": 0,
              "elementCount": 1
            }
          },
          "result": 0
        },
        "priority": 3,
        "words": {
          "wordCount": 13,
          "wordValue": 0.1,
          "result": 0.88
        },
        "multiplier": 1,
        "relevance": 0.3
      }
    }
  ],
  "permitUrl": "https://pay.ubq.fi?claim=W3sidHlwZSI6ImVyYzIwLXBlcm1pdCIsInBlcm1pdCI6eyJwZXJtaXR0ZWQiOnsidG9rZW4iOiIweGU5MUQxNTNFMGI0MTUxOEEyQ2U4RGQzRDc5NDRGYTg2MzQ2M2E5N2QiLCJhbW91bnQiOiIxMTA4NzQwMDAwMDAwMDAwMDAwMDAifSwibm9uY2UiOiI2MDA3MzE0Mjc3Njg5MzE5OTkyMTI1ODE2NjcwNjc1NTczMDA4Mzg3NTI4Nzk1NDM2MDIwNDYwNjQ2MzY0ODAzMTQ5OTA5ODM4OTU0MiIsImRlYWRsaW5lIjoiMTE1NzkyMDg5MjM3MzE2MTk1NDIzNTcwOTg1MDA4Njg3OTA3ODUzMjY5OTg0NjY1NjQwNTY0MDM5NDU3NTg0MDA3OTEzMTI5NjM5OTM1In0sInRyYW5zZmVyRGV0YWlscyI6eyJ0byI6IjB4NDAwN0NFMjA4M2M3RjNFMTgwOTdhZUIzQTM5YmI4ZUMxNDlhMzQxZCIsInJlcXVlc3RlZEFtb3VudCI6IjExMDg3NDAwMDAwMDAwMDAwMDAwMCJ9LCJvd25lciI6IjB4OTA1MWVEYTk2ZEI0MTljOTY3MTg5RjRBYzMwM2EyOTBGMzMyNzY4MCIsInNpZ25hdHVyZSI6IjB4MDAzZThmZWUzYmQyMWE2NDM4NDFkN2UyOWRjNzBlNWYwNDUzOTc3ZTg3YzNkMzgyOGYyNzk2ZDk0MDhmNWQ0NjM2ZTIzODQ0MmRkODc2ZmY1ZWU3MDUzMGZkNTQ5OGNjMWY1NzBkZTM3NGMwMDcyZTZmMDhkYzg3MDU0OGViYjUxYyIsIm5ldHdvcmtJZCI6MTAwfV0="
},
"Keyrxng": {
  "total": 0.3,
  "userId": 106303466,
  "comments": [
    {
      "id": 2495477579,
      "content": "I'm happy to get back to performing reviews - I just need the green light.",
      "url": "https://github.com/ubiquity-os-marketplace/text-conversation-rewards/pull/188#issuecomment-2495477579",
      "type": "PULL_COLLABORATOR",
      "score": {
        "reward": 0.3,
        "formatting": {
          "content": {
            "p": {
              "score": 0,
              "elementCount": 1
            }
          },
          "result": 0
        },
        "priority": 3,
        "words": {
          "wordCount": 15,
          "wordValue": 0.1,
          "result": 1
        },
        "multiplier": 1,
        "relevance": 0.1
      }
    }
  ],
  "permitUrl": "https://pay.ubq.fi?claim=W3sidHlwZSI6ImVyYzIwLXBlcm1pdCIsInBlcm1pdCI6eyJwZXJtaXR0ZWQiOnsidG9rZW4iOiIweGU5MUQxNTNFMGI0MTUxOEEyQ2U4RGQzRDc5NDRGYTg2MzQ2M2E5N2QiLCJhbW91bnQiOiIzMDAwMDAwMDAwMDAwMDAwMDAifSwibm9uY2UiOiI4OTMwOTAzNTcyNDQ0Mzc0NjE4MTI2MDc1MDExMjI1MzM0MzgzNTQwNzAyMjU5MTQ4MzEwODc3MzExMzEwOTE4OTA4MjkxMDg5Mzg3MSIsImRlYWRsaW5lIjoiMTE1NzkyMDg5MjM3MzE2MTk1NDIzNTcwOTg1MDA4Njg3OTA3ODUzMjY5OTg0NjY1NjQwNTY0MDM5NDU3NTg0MDA3OTEzMTI5NjM5OTM1In0sInRyYW5zZmVyRGV0YWlscyI6eyJ0byI6IjB4QWU1RDFGMTkyMDEzZGI4ODliMWUyMTE1QTM3MGFCMTMzZjM1OTc2NSIsInJlcXVlc3RlZEFtb3VudCI6IjMwMDAwMDAwMDAwMDAwMDAwMCJ9LCJvd25lciI6IjB4OTA1MWVEYTk2ZEI0MTljOTY3MTg5RjRBYzMwM2EyOTBGMzMyNzY4MCIsInNpZ25hdHVyZSI6IjB4MTlkYjI2MmEyZDQ0MDUyNmUwYzZjNmJkMjQxMDYzYTllMDRjM2JhZTAxYWMxNjNlY2Y5ZTRmYjk0ZTU1NDBkYzQ2N2M4Njk3ODAyOGZkNGE0YzMzYjk4Y2JlYWVlMjlhNWZmYmI0NDMxYjljMzAxOWEwNmYwOWUxZGIyMTVmN2ExYiIsIm5ldHdvcmtJZCI6MTAwfV0="
}

}
}
-->

Originally posted by @ubiquity-os-beta[bot] in ubiquity-os-marketplace/text-conversation-rewards#155 (comment)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant