-
Notifications
You must be signed in to change notification settings - Fork 9
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Issue Dedupe #6
Comments
@sshivaditya2019 rfc |
This could be managed with a separate plugin if necessary. If |
/start |
Tips:
|
Reducing coupling is preferred just as long as it doesn't make the setup overly complicated. |
Is it possible to retrieve the currently active plugins from within a plugin? |
I'm assuming by parsing the current config. I'm pretty sure we have a method in our SDK for this @whilefoo do you know? |
This comment was marked as spam.
This comment was marked as spam.
You should check the original conversation and pull instead of speculating on how it's implemented. As I understand, each vector embedding has an ID (issue id, or comment id) GraphQL query of contributors "closed as complete" issues' IDs We just check those IDs' embeddings. |
My mistake I misread this as within the org and I didn't think there would be any reliance on graphql or rest. I thought we'd cover all issues not just closed as complete and the embeddings would have relevant metadata to help filtering. When working with embeddings previously such as chunking pdfs etc they'd have relevant metadata for each chunk and I was considering each of ours as one chunk. I guess centralizing the embedding db was also sort of mentioned too so yeah my bad I'll hide the comment and go get another coffee 😂 |
No we don't have that method. Since both plugins would share the same database, maybe it would be better to keep it as one plugin? |
@0x4007 To get the facts straight:
Please let me know if there are any errors or if further adjustments are needed. |
All correct |
Should this plugin just be rebranded to A rebranding makes sense because Features such as |
It's done |
I think this blocked by #8, once we are able to nail down a schema, this should be good to go. |
I decided on a schema there |
@sshivaditya2019, this task has been idle for a while. Please provide an update. |
Combining in PR #9 |
@0x4007 Does the I think this is a issue, with |
Pulls need to be separated.
Try issues plural instead. Check the type definitions. |
|
View | Contribution | Count | Reward |
---|---|---|---|
Issue | Task | 1 | 600 |
Issue | Comment | 6 | 9.534 |
Review | Comment | 12 | 0 |
Conversation Incentives
Comment | Formatting | Relevance | Reward |
---|---|---|---|
This could be managed with a separate plugin if necessary. If &#… | 2.79content: p: symbols: \b\w+\b: count: 48 multiplier: 0.1 score: 1 code: symbols: \b\w+\b: count: 1 multiplier: 0.1 score: 1 multiplier: 1 | 0.8 | 2.232 |
Is it possible to retrieve the currently active plugins from wit… | 0.88content: p: symbols: \b\w+\b: count: 13 multiplier: 0.1 score: 1 multiplier: 1 | 0.3 | 0.264 |
@0x4007 I think it would be better to make this as an extensio… | 5.09content: p: symbols: \b\w+\b: count: 76 multiplier: 0.1 score: 1 code: symbols: \b\w+\b: count: 11 multiplier: 0.1 score: 1 ul: symbols: \b\w+\b: count: 1 multiplier: 0.1 score: 1 li: symbols: \b\w+\b: count: 3 multiplier: 0.1 score: 1 multiplier: 1 | 0.9 | 4.581 |
I think this blocked by #8, once we are able to nail down a sche… | 1.33content: p: symbols: \b\w+\b: count: 21 multiplier: 0.1 score: 1 multiplier: 1 | 0.6 | 0.798 |
Combining in PR #9 | 0.32content: p: symbols: \b\w+\b: count: 4 multiplier: 0.1 score: 1 multiplier: 1 | 0.2 | 0.064 |
@0x4007 Does the `ubiquibot-kernel`, support `issue.… | 3.19content: p: symbols: \b\w+\b: count: 29 multiplier: 0.1 score: 1 code: symbols: \b\w+\b: count: 23 multiplier: 0.1 score: 1 multiplier: 1 | 0.5 | 1.595 |
Resolves #6 | 0content: p: symbols: \b\w+\b: count: 2 multiplier: 0 score: 1 multiplier: 0 | 0.1 | - |
@0x4007 This function handles only the deduplication process, if… | 0content: p: symbols: \b\w+\b: count: 43 multiplier: 0.2 score: 1 code: symbols: \b\w+\b: count: 2 multiplier: 0.2 score: 1 multiplier: 0 | 1 | - |
A cosine similarity of 0.75 appears quite close for identifying … | 0content: p: symbols: \b\w+\b: count: 58 multiplier: 0.2 score: 1 multiplier: 0 | 1 | - |
Removed. | 0content: p: symbols: \b\w+\b: count: 1 multiplier: 0.2 score: 1 multiplier: 0 | 1 | - |
Removed Labels. Labels will not be added on issue close | 0content: p: symbols: \b\w+\b: count: 10 multiplier: 0.2 score: 1 multiplier: 0 | 1 | - |
So, for both `Match` and `Warning` threshold, th… | 0content: p: symbols: \b\w+\b: count: 16 multiplier: 0.2 score: 1 code: symbols: \b\w+\b: count: 2 multiplier: 0.2 score: 1 multiplier: 0 | 1 | - |
Added, Now it fetches the values from the `context.config … | 0content: p: symbols: \b\w+\b: count: 8 multiplier: 0.2 score: 1 code: symbols: \b\w+\b: count: 2 multiplier: 0.2 score: 1 multiplier: 0 | 1 | - |
@0x4007 I have tried to make a few examples, let me know if hav… | 0content: p: symbols: \b\w+\b: count: 31 multiplier: 0.2 score: 1 multiplier: 0 | 1 | - |
Added They will display the cosine similarity in percentage afte… | 0content: p: symbols: \b\w+\b: count: 30 multiplier: 0.2 score: 1 multiplier: 0 | 1 | - |
95%: - [First Comment](https://github.com/sshivaditya2019/test-… | 0content: p: symbols: \b\w+\b: count: 22 multiplier: 0.2 score: 1 ul: symbols: \b\w+\b: count: 2 multiplier: 0.2 score: 1 li: symbols: \b\w+\b: count: 4 multiplier: 0.2 score: 1 a: symbols: \b\w+\b: count: 11 multiplier: 0.2 score: 1 multiplier: 0 | 1 | - |
Fixed that, it now returns the similar issue in both `MATCH&… | 0content: p: symbols: \b\w+\b: count: 23 multiplier: 0.2 score: 1 code: symbols: \b\w+\b: count: 2 multiplier: 0.2 score: 1 ul: symbols: \b\w+\b: count: 2 multiplier: 0.2 score: 1 li: symbols: \b\w+\b: count: 4 multiplier: 0.2 score: 1 a: symbols: \b\w+\b: count: 8 multiplier: 0.2 score: 1 multiplier: 0 | 1 | - |
That's the first issue of that type, so its expected to not have… | 0content: p: symbols: \b\w+\b: count: 63 multiplier: 0.2 score: 1 multiplier: 0 | 1 | - |
[ 41.438 WXDAI ]
@0x4007
Contributions Overview
View | Contribution | Count | Reward |
---|---|---|---|
Issue | Specification | 1 | 24.5 |
Issue | Comment | 8 | 5.388 |
Review | Comment | 12 | 11.55 |
Conversation Incentives
Comment | Formatting | Relevance | Reward |
---|---|---|---|
On `issue.created` and `issue.edited` we should … | 24.5content: p: symbols: \b\w+\b: count: 24 multiplier: 0.1 score: 1 code: symbols: \b\w+\b: count: 5 multiplier: 0.1 score: 5 ol: symbols: \b\w+\b: count: 1 multiplier: 0.1 score: 0 li: symbols: \b\w+\b: count: 93 multiplier: 0.1 score: 1 ul: symbols: \b\w+\b: count: 1 multiplier: 0.1 score: 0 multiplier: 3 | 1 | 24.5 |
@sshivaditya2019 rfc | 0.36content: p: symbols: \b\w+\b: count: 2 multiplier: 0.2 score: 1 multiplier: 1 | 0.1 | 0.036 |
Reducing coupling is preferred just as long as it doesn't make t… | 2.11content: p: symbols: \b\w+\b: count: 16 multiplier: 0.2 score: 1 multiplier: 1 | 0.2 | 0.422 |
@gentlementlegen @Keyrxng RFC I'm assuming by parsing the curren… | 3.4content: p: symbols: \b\w+\b: count: 28 multiplier: 0.2 score: 1 multiplier: 1 | 0.3 | 1.02 |
You should check the original conversation and pull instead of s… | 5.08content: p: symbols: \b\w+\b: count: 45 multiplier: 0.2 score: 1 multiplier: 1 | 0.7 | 3.556 |
All correct | 0content: p: symbols: \b\w+\b: count: 2 multiplier: 0.2 score: 1 multiplier: 1 | - | - |
It's done | 0content: p: symbols: \b\w+\b: count: 3 multiplier: 0.2 score: 1 multiplier: 1 | - | - |
I decided on a schema there | 0content: p: symbols: \b\w+\b: count: 6 multiplier: 0.2 score: 1 multiplier: 1 | - | - |
Pulls need to be separated. Try issues plural instead. Check th… | 1.77content: p: symbols: \b\w+\b: count: 13 multiplier: 0.2 score: 1 multiplier: 1 | 0.2 | 0.354 |
- Adding labels is out of scope. Don't do that. Close it as unpl… | 2.45content: ul: symbols: \b\w+\b: count: 1 multiplier: 0.1 score: 1 li: symbols: \b\w+\b: count: 41 multiplier: 0.1 score: 1 multiplier: 1 | 1 | 2.45 |
Cool just needs configuration and I can merge. | 0.59content: p: symbols: \b\w+\b: count: 8 multiplier: 0.1 score: 1 multiplier: 1 | 1 | 0.59 |
I'm assuming it all works. Code looks good. | 0.65content: p: symbols: \b\w+\b: count: 9 multiplier: 0.1 score: 1 multiplier: 1 | 1 | 0.65 |
Needs to comment the similar issue link | 0.52content: p: symbols: \b\w+\b: count: 7 multiplier: 0.1 score: 1 multiplier: 1 | 1 | 0.52 |
It needs to always let the user know which it thinks is similar.… | 1.65content: p: symbols: \b\w+\b: count: 27 multiplier: 0.1 score: 1 multiplier: 1 | 1 | 1.65 |
Why did you do 50%? | 0.39content: p: symbols: \b\w+\b: count: 5 multiplier: 0.1 score: 1 multiplier: 1 | 1 | 0.39 |
No labels | 0.18content: p: symbols: \b\w+\b: count: 2 multiplier: 0.1 score: 1 multiplier: 1 | 1 | 0.18 |
What is going on here? Reopening issues is out of scope. | 0.77content: p: symbols: \b\w+\b: count: 11 multiplier: 0.1 score: 1 multiplier: 1 | 1 | 0.77 |
These should be configurable values. Can you see how configurati… | 1.06content: p: symbols: \b\w+\b: count: 16 multiplier: 0.1 score: 1 multiplier: 1 | 1 | 1.06 |
Can you link your issue where you tested so we can see the resul… | 0.94content: p: symbols: \b\w+\b: count: 14 multiplier: 0.1 score: 1 multiplier: 1 | 1 | 0.94 |
Okay it seems like you aren't following the spec again. Needs t… | 1.65content: p: symbols: \b\w+\b: count: 27 multiplier: 0.1 score: 1 multiplier: 1 | 1 | 1.65 |
Doesn't look like it in the [first one ](https://github.com/sshi… | 0.7content: p: symbols: \b\w+\b: count: 7 multiplier: 0.1 score: 1 a: symbols: \b\w+\b: count: 2 multiplier: 0.1 score: 1 multiplier: 1 | 1 | 0.7 |
[ 16.765 WXDAI ]
@Keyrxng
Contributions Overview
View | Contribution | Count | Reward |
---|---|---|---|
Issue | Comment | 3 | 16.765 |
Conversation Incentives
Comment | Formatting | Relevance | Reward |
---|---|---|---|
Yeah by parsing the private config file but I'm not sure why you… | 15.61content: p: symbols: \b\w+\b: count: 355 multiplier: 0.1 score: 1 hr: symbols: \b\w+\b: count: 3 multiplier: 0.1 score: 0 code: symbols: \b\w+\b: count: 4 multiplier: 0.1 score: 1 ul: symbols: \b\w+\b: count: 2 multiplier: 0.1 score: 1 li: symbols: \b\w+\b: count: 5 multiplier: 0.1 score: 1 multiplier: 1 | 0.8 | 12.488 |
My mistake I misread this as within the org and I didn't think t… | 4.97content: p: symbols: \b\w+\b: count: 99 multiplier: 0.1 score: 1 multiplier: 1 | 0.2 | 0.994 |
Should this plugin just be rebranded to `embeddings-plugin&#… | 4.69content: p: symbols: \b\w+\b: count: 82 multiplier: 0.1 score: 1 code: symbols: \b\w+\b: count: 6 multiplier: 0.1 score: 1 multiplier: 1 | 0.7 | 3.283 |
[ 0.32 WXDAI ]
@whilefoo
Contributions Overview
View | Contribution | Count | Reward |
---|---|---|---|
Issue | Comment | 1 | 0.32 |
Conversation Incentives
Comment | Formatting | Relevance | Reward |
---|---|---|---|
No we don't have that method. Since both plugins would share th… | 0.4content: p: symbols: \b\w+\b: count: 26 multiplier: 0.1 score: 1 multiplier: 0.25 | 0.8 | 0.32 |
@ubiquibot/software-development can somebody install this |
On
issue.created
andissue.edited
we should check if there are any open issues that are x% similar within the repository. There should be two configurable percentages:warning
threshold, perhaps 75% similar as a defaultIt isn't entirely clear to me if this should be a separate plug-in, but this does require coupling to the same vector embeddings database. Another idea is to pass in the authentication details in each vector embeddings related plugin's config.
The text was updated successfully, but these errors were encountered: