Contributor Approvals Should Not Be Considered #22
Comments
|
/start |
Tip
|
|
@YanVictorSN, this task has been idle for a while. Please provide an update. |
9 similar comments
|
@YanVictorSN, this task has been idle for a while. Please provide an update. |
|
@YanVictorSN, this task has been idle for a while. Please provide an update. |
|
@YanVictorSN, this task has been idle for a while. Please provide an update. |
|
@YanVictorSN, this task has been idle for a while. Please provide an update. |
|
@YanVictorSN, this task has been idle for a while. Please provide an update. |
|
@YanVictorSN, this task has been idle for a while. Please provide an update. |
|
@YanVictorSN, this task has been idle for a while. Please provide an update. |
|
@YanVictorSN, this task has been idle for a while. Please provide an update. |
|
@YanVictorSN, this task has been idle for a while. Please provide an update. |
|
@Keyrxng It seems that the reminders are going wild with this issue, any idea about what's going on? |
|
@YanVictorSN, this task has been idle for a while. Please provide an update. |
9 similar comments
|
@YanVictorSN, this task has been idle for a while. Please provide an update. |
|
@YanVictorSN, this task has been idle for a while. Please provide an update. |
|
@YanVictorSN, this task has been idle for a while. Please provide an update. |
|
@YanVictorSN, this task has been idle for a while. Please provide an update. |
|
@YanVictorSN, this task has been idle for a while. Please provide an update. |
|
@YanVictorSN, this task has been idle for a while. Please provide an update. |
|
@YanVictorSN, this task has been idle for a while. Please provide an update. |
|
@YanVictorSN, this task has been idle for a while. Please provide an update. |
|
@YanVictorSN, this task has been idle for a while. Please provide an update. |
|
@YanVictorSN, this task has been idle for a while. Please provide an update. |
Currenty working on the QA tests. |
|
Passed the deadline and no activity is detected, removing assignees: @YanVictorSN. |
|
Disqualify needs to close the pull |
|
This would be the responsibility of https://github.com/ubiquity-os-marketplace/command-start-stop |
|
Latch on to the unassign event and then search for pulls to close? Yes makes sense. |
|
Yes that plugin was made to react to un-assignments so having it in the merging plugin would be redundant. However this seems not to work so I'l check what's going on. |
|
/start |
|
Warning You have reached your max task limit. Please close out some tasks before assigning new ones. |
|
I am waiting on reviews on both of them with qa's and tests both passing, only some refactoring suggestions were left |
|
I'll wait until they get merged |
|
@ishowvel the deadline is at Mon, Nov 18, 11:13 AM UTC |
|
A new workroom has been created for this task. Join chat |
|
/stop |
|
#27 should be merged first to avoid major conflicts, since it adds the SDK to this plugin. |
|
@gentlementlegen the deadline is at Mon, Nov 25, 4:45 AM UTC |
+ Evaluating results. Please wait... |
|
| View | Contribution | Count | Reward |
|---|---|---|---|
| Issue | Task | 1 | 75 |
| Issue | Comment | 4 | 1.04925 |
| Review | Comment | 1 | 0 |
Conversation Incentives
| Comment | Formatting | Relevance | Priority | Reward |
|---|---|---|---|---|
@Keyrxng It seems that the reminders are going wild with this is… | 1.22content:
content:
p:
score: 0
elementCount: 1
result: 0
regex:
wordCount: 19
wordValue: 0.1
result: 1.22
| 0.5 | 3 | 0.4725 |
This would be the responsibility of https://github.com/ubiquity-… | 1content:
content:
p:
score: 0
elementCount: 1
result: 0
regex:
wordCount: 15
wordValue: 0.1
result: 1
| 0.2 | 3 | 0.15 |
Yes that plugin was made to react to un-assignments so having it… | 2content:
content:
p:
score: 0
elementCount: 1
result: 0
regex:
wordCount: 34
wordValue: 0.1
result: 2
| 0.2 | 3 | 0.3 |
https://github.com/ubiquity-os-marketplace/daemon-merging/pull/2… | 1.59content:
content:
p:
score: 0
elementCount: 1
result: 0
regex:
wordCount: 26
wordValue: 0.1
result: 1.59
| 0.1 | 3 | 0.12675 |
Resolves #22Depends on #27 | 0content:
content:
p:
score: 0
elementCount: 2
result: 0
regex:
wordCount: 5
wordValue: 0
result: 0
| 0.3 | 3 | 0 |
[ 0.1875 WXDAI ]
@YanVictorSN
Contributions Overview
| View | Contribution | Count | Reward |
|---|---|---|---|
| Issue | Comment | 1 | 0.1875 |
Conversation Incentives
| Comment | Formatting | Relevance | Priority | Reward |
|---|---|---|---|---|
Currenty working on the QA tests. | 0.46content:
content:
p:
score: 0
elementCount: 1
result: 0
regex:
wordCount: 6
wordValue: 0.1
result: 0.46
| 0.5 | 3 | 0.1875 |
[ 34.56 WXDAI ]
@0x4007
Contributions Overview
| View | Contribution | Count | Reward |
|---|---|---|---|
| Issue | Specification | 1 | 34.56 |
| Issue | Comment | 2 | 0 |
Conversation Incentives
| Comment | Formatting | Relevance | Priority | Reward |
|---|---|---|---|---|
This doesn't make any sense to consider outsider approvals to au… | 3.84content:
content:
p:
score: 0
elementCount: 3
result: 0
regex:
wordCount: 73
wordValue: 0.1
result: 3.84
| 1 | 3 | 34.56 |
Disqualify needs to close the pull | 0.46content:
content:
p:
score: 0
elementCount: 1
result: 0
regex:
wordCount: 6
wordValue: 0.1
result: 0.46
| 0 | 3 | 0 |
Latch on to the unassign event and then search for pulls to clos… | 1.06content:
content:
p:
score: 0
elementCount: 1
result: 0
regex:
wordCount: 16
wordValue: 0.1
result: 1.06
| 0 | 3 | 0 |
[ 0.015 WXDAI ]
@ishowvel
Contributions Overview
| View | Contribution | Count | Reward |
|---|---|---|---|
| Issue | Comment | 2 | 0.015 |
Conversation Incentives
| Comment | Formatting | Relevance | Priority | Reward |
|---|---|---|---|---|
I am waiting on reviews on both of them with qa's and tests both… | 1.38content:
content:
p:
score: 0
elementCount: 1
result: 0
regex:
wordCount: 22
wordValue: 0.1
result: 1.38
| 0 | 3 | 0.015 |
I'll wait until they get merged | 0.52content:
content:
p:
score: 0
elementCount: 1
result: 0
regex:
wordCount: 7
wordValue: 0.1
result: 0.52
| 0 | 3 | 0 |
This doesn't make any sense to consider outsider approvals to automatically merge into our code, let alone default to 2. This logic should be removed.
In theory it could be possible to run an org with a single member using this system but seems very unusual. I would remove this logic related to considering contributor approvals.
daemon-merging/src/types/plugin-inputs.ts
Line 25 in b9e0cf3
The text was updated successfully, but these errors were encountered: