-
Notifications
You must be signed in to change notification settings - Fork 13
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use the proper configuration (repo scoped) #68
Comments
@0x4007 continuing the discussion here to not pollute the other issue. I think the proper solution is to only run the |
I disagree. There's many repos without much activity and a few with the most so the former would be very unmaintained by the disqualifier. Instead the disqualifier should build a mapping of every (merged) config to every repo. Ideally it should use the identical SDK logic the kernel uses to interpret the configs. |
Then we should simply ensure that the disqualifier runs not based on event but time intervals. Having the disqualifier being able to read configs would just lead to code duplication and complex workflow logic, which should be avoided. Also if the base org does not have the disqualifer but the repo does have it, it means that either way events would only be triggered from this repo and the config would apply to other repos (which should not happen since the org does not have the plugin enabled). |
I'm not convinced. I think the SDK handles most of the config related logic so duplication is fine because it's imported. |
The SDK does not handle the configuration for plugins, only the kernel knows how to read / decode / validate it. Plugins are only aware of their own configuration which is sent by the kernel. Consider the following scenario:
in this case, the |
Originally posted by @gentlementlegen in ubiquity/business-development#103 (comment)
The text was updated successfully, but these errors were encountered: