Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reviewer Follow Ups #49

Open
0x4007 opened this issue Nov 21, 2024 · 1 comment
Open

Reviewer Follow Ups #49

0x4007 opened this issue Nov 21, 2024 · 1 comment

Comments

@0x4007
Copy link
Member

0x4007 commented Nov 21, 2024

Sometimes reviewers are slow and the follow ups will keep pinging the assignee even though they are finished with their work.

This will require us to change our standard operating procedure to convert back to draft pull request if we think the pull is not ready to go. This I am hesitant for because if it's a private repo then they must pay for GitHub premium to support draft pulls. Perhaps we can incorporate some logic for when we request changes, then we know the pull is not ready. We can discuss.

--

If the pull is ready then it should follow up with reviewers. If it isn’t ready (draft) then it should follow up with the assignee(s).

If the contributor stops working on the task they will be reminded. Either they should unassign themselves, continue working, or convert the draft to a finalized pull.

https://t.me/UbiquityDevPool/2960

@0x4007
Copy link
Member Author

0x4007 commented Nov 21, 2024

Related #48

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant