Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Follow up enhancements #23

Closed
0x4007 opened this issue Sep 21, 2024 · 12 comments · Fixed by #36
Closed

Follow up enhancements #23

0x4007 opened this issue Sep 21, 2024 · 12 comments · Fixed by #36

Comments

@0x4007
Copy link
Member

0x4007 commented Sep 21, 2024

  1. Follow up should be on pull request so that they don't reply under issue and get paid for it.
  2. If there isn't a pull request open in time for the warning, automatically disqualify them (they should open a draft pull as soon as they self assign)
    • Must be configurable since some tasks are not coding related.
    • If pull isn't required then follow up under issue as we do now.
  3. "activity which should be considered is only the one from the assignees themselves. I believe currently any activity from anyone is considered in the events."
@gentlementlegen
Copy link
Member

I think we can also add the point that the activity which should be considered is only the one from the assignees themselves. I believe currently any activity from anyone is considered in the events.

Copy link
Contributor

ubiquity-os bot commented Oct 14, 2024

@gentlementlegen the deadline is at Mon, Oct 14, 8:11 PM UTC

1 similar comment
Copy link

@gentlementlegen the deadline is at Mon, Oct 14, 8:11 PM UTC

Copy link

@gentlementlegen the deadline is at Tue, Oct 15, 3:22 AM UTC

1 similar comment
Copy link
Contributor

ubiquity-os bot commented Oct 14, 2024

@gentlementlegen the deadline is at Tue, Oct 15, 3:22 AM UTC

@gentlementlegen
Copy link
Member

@0x4007 For the configurable part on "no PR = unassign" policy, it feels like it should be issue based but we don't have configuration on a issue basis, the finer we have is repo scoped. Is that fine enough?

@0x4007
Copy link
Member Author

0x4007 commented Oct 22, 2024

I think repo scoped is probably fine for now

@gentlementlegen
Copy link
Member

gentlementlegen commented Oct 22, 2024

Maybe we should start using Discussions for issues that do not require pull-request, and add the capability to incentivize these. I'll do that repo scoped in the meantime then. My second idea was to add a special title to these issues like [no-pr] or something similar that would tell this issue won't have a pull request.

If we comment on the PR, we should also consider the case when multiple PRs are opened. Should all of them get the reminder?

@0x4007
Copy link
Member Author

0x4007 commented Oct 22, 2024

If we comment on the PR, we should also consider the case when multiple PRs are opened. Should all of them get the reminder?

Makes sense, and the disqualified candidates should have theirs closed so no more reminders.

Discussions might make sense to use! We tried back a couple years ago to use discussions as "proposals" but evolved the system to stay inside of issues and get them funded to make them "official tasks."

Copy link

ubiquity-os-beta bot commented Oct 24, 2024

 [ 300 WXDAI ] 

@gentlementlegen
Contributions Overview
ViewContributionCountReward
IssueTask1300
IssueComment30
ReviewComment50
Conversation Incentives
CommentFormattingRelevanceReward
I think we can also add the point that the activity which should…
0
content:
  content:
    p:
      score: 0
      elementCount: 1
  result: 0
regex:
  wordCount: 35
  wordValue: 0
  result: 0
0.80
@0x4007 For the configurable part on "no PR = unassign" policy, …
0
content:
  content:
    p:
      score: 0
      elementCount: 1
  result: 0
regex:
  wordCount: 39
  wordValue: 0
  result: 0
0.60
Maybe we should start using [Discussions](https://docs.github.co…
5
content:
  content:
    p:
      score: 0
      elementCount: 2
    a:
      score: 5
      elementCount: 1
  result: 5
regex:
  wordCount: 82
  wordValue: 0
  result: 0
0.70
Resolves #23QA: https://github.com/Meniole/user-activity-watch…
0
content:
  content:
    p:
      score: 0
      elementCount: 2
  result: 0
regex:
  wordCount: 12
  wordValue: 0
  result: 0
0.20
`undefined` is checked, the shift is on purpose, to chec…
0
content:
  content:
    p:
      score: 0
      elementCount: 1
  result: 0
regex:
  wordCount: 55
  wordValue: 0
  result: 0
0.80
`activityDate` can be undefined if the user just assigne…
0
content:
  content:
    p:
      score: 0
      elementCount: 1
  result: 0
regex:
  wordCount: 42
  wordValue: 0
  result: 0
0.70
Sure, will change it. Thought it was not useful because the netw…
0
content:
  content:
    p:
      score: 0
      elementCount: 1
  result: 0
regex:
  wordCount: 20
  wordValue: 0
  result: 0
0.60
@whilefoo @Keyrxng if you want to have a look, I can't assign yo…
0
content:
  content:
    p:
      score: 0
      elementCount: 1
  result: 0
regex:
  wordCount: 16
  wordValue: 0
  result: 0
0.10

 [ 32.881 WXDAI ] 

@0x4007
Contributions Overview
ViewContributionCountReward
IssueSpecification128.14
IssueComment22.336
ReviewComment42.405
Conversation Incentives
CommentFormattingRelevanceReward
1. Follow up should be on pull request so that they don't reply …
9.38
content:
  content:
    ol:
      score: 1
      elementCount: 1
    li:
      score: 0.5
      elementCount: 5
    p:
      score: 0
      elementCount: 5
    ul:
      score: 1
      elementCount: 1
  result: 4.5
regex:
  wordCount: 97
  wordValue: 0.1
  result: 4.88
128.14
I think repo scoped is probably fine for now
0.65
content:
  content:
    p:
      score: 0
      elementCount: 1
  result: 0
regex:
  wordCount: 9
  wordValue: 0.1
  result: 0.65
0.60.39
Makes sense, and the disqualified candidates should have theirs …
2.78
content:
  content:
    p:
      score: 0
      elementCount: 2
  result: 0
regex:
  wordCount: 50
  wordValue: 0.1
  result: 2.78
0.71.946
```suggestiondescription: "Used for authen…
0
content:
  content: {}
  result: 0
regex:
  wordCount: 0
  wordValue: 0.1
  result: 0
0.60
How about a statusCode: 200 instead
0.46
content:
  content:
    p:
      score: 0
      elementCount: 1
  result: 0
regex:
  wordCount: 6
  wordValue: 0.1
  result: 0.46
0.40.184
This looks like this can shift an `undefined` value, I d…
2.05
content:
  content:
    p:
      score: 0
      elementCount: 1
  result: 0
regex:
  wordCount: 35
  wordValue: 0.1
  result: 2.05
0.81.64
I think it should never be undefined. You should throw for that.
0.83
content:
  content:
    p:
      score: 0
      elementCount: 1
  result: 0
regex:
  wordCount: 12
  wordValue: 0.1
  result: 0.83
0.70.581

 [ 0.0285 WXDAI ] 

@Keyrxng
Contributions Overview
ViewContributionCountReward
ReviewComment10.0285
Conversation Incentives
CommentFormattingRelevanceReward
Just about to clock off bud but I'm happy to after I wake.
0.94
content:
  content:
    p:
      score: 0
      elementCount: 1
  result: 0
regex:
  wordCount: 14
  wordValue: 0.1
  result: 0.94
0.10.0285

@0x4007
Copy link
Member Author

0x4007 commented Oct 24, 2024

I realize that we will lose a lot of other plugin capabilities by switching over to discussions. So it might not be a good idea.

Alternatively we upgrade every plugin to support discussions, which also doesn't seem like a good idea.

Like daemon-pricing comes to mind.

@gentlementlegen
Copy link
Member

I think we could implement our plugins to support discussions. Discussions have tags as well so our logic could apply there, amd closing the discussions, what we miss is the collection of comments: Meniole/text-conversation-rewards#25

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants