Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Incorrect conversion factor in PowerRamp units per minute and per hour #587

Open
mzboray opened this issue Apr 5, 2023 · 1 comment
Open

Incorrect conversion factor in PowerRamp units per minute and per hour #587

mzboray opened this issue Apr 5, 2023 · 1 comment

Comments

@mzboray
Copy link

mzboray commented Apr 5, 2023

Specifically the conversion between units such as WattsPerMinute and WattsPerHour are incorrect, see PowerRampSpec:

WattsPerHour(1) should be(WattsPerMinute(60))

This should be WattsPerHour(3600) should be(WattsPerMinute(60))

Also the types in PowerRamp use "m" for minutes in their symbols, but this is incorrect and "min" should be used. See Non-SI units mentioned in the SI.
@charlietsai
Copy link

Seeing the same issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@mzboray @charlietsai