Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Incorrect type hint for api_settings.ALLOWED_VERSIONS #200

Open
brent-moffit opened this issue Mar 21, 2022 · 0 comments
Open

Incorrect type hint for api_settings.ALLOWED_VERSIONS #200

brent-moffit opened this issue Mar 21, 2022 · 0 comments
Labels
bug Something isn't working

Comments

@brent-moffit
Copy link

Bug report

What's wrong

in settings.pyi the type of ALLOWED_VERSIONS is hinted to Optional[str].

How is that should be

This setting is typically a list of allowed version strings and should be typed as Optional[List[str]] or similar.

System information

  • OS:
  • python version: 3.8.10
  • django version: 3.2.10
  • mypy version: 0.930
  • django-stubs version: 1.9.0
  • djangorestframework-stubs version: 1.4.0
@brent-moffit brent-moffit added the bug Something isn't working label Mar 21, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working
Milestone
No milestone
Development

No branches or pull requests
1 participant
@brent-moffit