chore: Upload cache only from test jobs #4077
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
KapJI
force-pushed
the
better-caching
branch
8 times, most recently
from
b3498a4
to
7cd1401
Compare
KapJI
force-pushed
the
better-caching
branch
4 times, most recently
from
03a0478
to
5043558
Compare
KapJI
force-pushed
the
better-caching
branch
from
5043558
to
72c2024
Compare
|
Awesome, thank you! |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
macos-15. They can share the same cache entry now, so this saves one cache entry.test-ubuntujobs toubuntu-22.04. Using old glibc only makes sense for release jobs. Using the same ubuntu version as for all other jobs allows sharing cache more effectively.test-ubuntu-umask0xxjob.Results
codeql: 2m56s -> 2m18s, 21% fastertest-ubuntu-umask002: 6m43s -> 5m35s, 17% fastertest-ubuntu-umask022: 7m29s -> 6m12s, 17% fastertest-windows: 7m14s -> 6m12s, 14% fastertest-macos: 8m46s -> 8m32s. Here cache was already uploaded from the same job (becauselint-macosis ARM and this was X64), the difference is from changing runner.macOS-x64cache entry, saved 400 MB.