bad character U+002D '-' whith install script

[zany130]

trying setup some scripts in chezmoi to inall some common packages I use on on atomic fedora but its complaining about a bad character.

chezmoi apply
chezmoi: install-packages.sh: template: run_onchange_install-packages.sh.tmpl:3: bad character U+002D '-'

so far I have (taken from https://www.chezmoi.io/user-guide/advanced/install-packages-declaratively/)

───────┬────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────
       │ File: .chezmoidata/packages.yaml
───────┼────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────
   1   │ packages:
   2   │     rpm-tree:
   3   │     - applet-window-buttons
   4   │     - krdp
   5   │     - kvantum
   6   │     pip:
   7   │     - solaar
   8   │     - organize-tool
   9   │     cargo:
  10   │     - cargo-install-update
  11   │     - clipboard-sync
  12   │     fisher:
  13   │     - jorgebucaran/fisher
  14   │     - ajeetdsouza/zoxide
  15   │     - ilancosman/tide@v6
  16   │     - jorgebucaran/autopair.fish
  17   │     - joseluisq/[email protected]
  18   │     - franciscolourenco/done
  19   │     - edc/bass
  20   │     - patrickf1/colored_man_pages.fish
  21   │     - b4b4r07/enhancd
  22   │     - jethrokuan/fzf
  23   │     - oh-my-fish/plugin-sudope
  24   │     

and

───────┬────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────
       │ File: run_onchange_install-packages.sh.tmpl
───────┼────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────
   1   │ #!/bin/bash
   2   │ if  command -v rpm-ostree >/dev/null; then
   3   │    {{ range .packages.rpm-tree -}}
   4   │    sudo rpm-ostree install {{ . | quote }}
   5   │    {{ end -}}
   6   │ fi
   7   │ {{ range .packages.pip -}}
   8   │ pip install -- user {{ . | quote }}
   9   │ {{ end -}}
  10   │ {{ range .packages.cargo -}}
  11   │ cargo install {{ . | quote }}
  12   │ {{ end -}}
  13   │ {{ range .packages.fisher -}}
  14   │ fisher install {{ . | quote }}
  15   │ {{ end -}}
  16   │ EOF
  17   │ {{ end -}}
───────┴────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────

[twpayne]

Is your YAML file valid? I suspect that you might have an invalid hyphen-like character in there.

[twpayne]

Maybe you're a victim of one of YAML's horrors? https://ruudvanasseldonk.com/2023/01/11/the-yaml-document-from-hell

[zany130]

nope doesn't seem like it anyway I have

pip:
- solar
- organize-tool

which is not causing issues...

[twpayne]

For reference, chezmoi uses Go's text/template library for parsing templates, so if you've found a genuine issue then it's genuine issue in a widely-used major software project. Not saying that it's not an issue, just that a minimal example that reproduces the problem would help everyone.

[zany130]

🤦 the issue was the name of my rpm-tree category specficcly the - in rpm-tree renamed it to rpmtree in both files and it worked

also for good measure I wrapped all the - package name with single quotes just in case

edit cool and my if statement also works!

the end result is this

packages:
    rpmtree:
    - 'applet-window-buttons'
    - 'krdp'
    - 'kvantum'
    pip:
    - 'solaar'
    - 'organize-tool'
    cargo:
    - 'cargo-install-update'
    - 'clipboard-sync'
    fisher:
    - 'jorgebucaran/fisher'
    - 'ajeetdsouza/zoxide'
    - 'ilancosman/tide@v6'
    - 'jorgebucaran/autopair.fish'
    - 'joseluisq/[email protected]'
    - 'franciscolourenco/done'
    - 'edc/bass'
    - 'patrickf1/colored_man_pages.fish'
    - 'b4b4r07/enhancd'
    - 'jethrokuan/fzf'
    - 'oh-my-fish/plugin-sudope'

#!/bin/bash
if  command -v rpm-ostree >/dev/null; then
	{{ range .packages.rpmtree -}}
	sudo rpm-ostree install {{ . | quote }}
	{{ end -}}
fi
{{ range .packages.pip -}}
pip install -- user {{ . | quote }}
{{ end -}}
{{ range .packages.cargo -}}
cargo install {{ . | quote }}
{{ end -}}
{{ range .packages.fisher -}}
fisher install {{ . | quote }}
{{ end -}}

btw solution to fisher packages was to add this script which uses fish

──────┬─────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────
       │ File: run_onchange_install-fish-plugins.sh.tmpl
───────┼─────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────
   1   │ #!/bin/fish
   2   │ {{ range .packages.fisher -}}
   3   │ fisher install {{ . | quote }}
   4   │ {{ end -}}

[zany130]

only problem now is that fisher is only a valid command when in fish shell . 😅 but the rest works !

[twpayne]

Very happy to hear that this is resolved and thank you for your patience in resolving it!

[halostatue]

The trick here is that Go templates do not allow dashes in bare map key names (.packages.rpm-tree is not legal), but you can always use indexing and quoted strings: .packages["rpm-tree"].